Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matnwb cannot read output NWB file #81

Open
CBroz1 opened this issue Jun 27, 2022 · 6 comments
Open

matnwb cannot read output NWB file #81

CBroz1 opened this issue Jun 27, 2022 · 6 comments
Labels
bug Something isn't working NWB

Comments

@CBroz1
Copy link
Contributor

CBroz1 commented Jun 27, 2022

A user reported difficulty reading an nwb file produced by the export function.

Screenshot 2022-06-27 at 18 04 43

@bendichter - Should files exported here be readable with matnwb ?

@CBroz1 CBroz1 added bug Something isn't working NWB labels Jun 27, 2022
@bendichter
Copy link
Contributor

@CBroz1 yes it should be. Would you be able to send me this file? @lawrence-mbf, do you have any idea what might be going on here?

@CBroz1
Copy link
Contributor Author

CBroz1 commented Jul 1, 2022

@CBroz1 yes it should be. Would you be able to send me this file?

Of course. I'll send over slack. Thanks for looking into it!

@lawrence-mbf
Copy link

@CBroz1 This unfortunately is a really old issue where MatNWB doesn't support anonymous type definitions: NeurodataWithoutBorders/matnwb#43

Thankfully, I think this is localised in the waveform_mean VectorData object as we haven't seen the same elsewhere. A workaround could just be to make a waveform_mean_unit vectordata object if you really need it in MatNWB.

@CBroz1
Copy link
Contributor Author

CBroz1 commented Jul 5, 2022

Thanks @lawrence-mbf for your insights!

@kabilar - I'm thinking we should make that edit so resulting files are more accessible. What do you think?

@kabilar
Copy link
Collaborator

kabilar commented Jul 5, 2022

Thanks all. Yes, let's make the update. I couldn't find documentation on waveform_mean_unit so not sure how we would make this update.

@lawrence-mbf
Copy link

@kabilar @CBroz1 It would really just be repeating that unit value as a vector column with the same number of rows. It is an ugly duplication of code and may one day throw warnings when validating but it will guarantee MatNWB support for now.

@kabilar kabilar added this to the 2022Q3 milestone Jul 5, 2022
@kabilar kabilar removed this from the 2022Q3 milestone Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working NWB
Projects
None yet
Development

No branches or pull requests

4 participants