Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for healthchecks and depends_on functionality on docker services that are extended #101

Open
guzman-raphael opened this issue Mar 31, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@guzman-raphael
Copy link
Collaborator

Feature Request

Problem

Currently if you attempt use extends on Docker Compose services with a depends_on configuration, it will throw an error.

Requirements

  • Allow healthchecks to facilitate bringing services up in correct order
  • Allow the extension or inheritance of services with such checks

Justification

This provides a healthy system and easy to diagnose the offending service.

Alternative Considerations

  • Docker Compose extends and depends_on in 2.4 version.
  • Multiple Docker Compose files.
  • Docker Compose 3.X with checks specific to the container so they can be brought up in any order

Related Errors

For example:

rguzman@ALPHA:/github/datajoint-labbook$ PY_VER=3.8 IMAGE=djbase DISTRO=alpine PHARUS_VERSION=$(cat pharus/pharus/version.py | tail -1 | awk -F\' '{print $2}') DJLABBOOK_VERSION=$(cat package.json | grep \"version\" | awk -F\" '{print $4}') HOST_UID=$(id -u) docker-compose -f docker-compose-dev.yaml up --build
ERROR: Cannot extend service 'pharus' in /github/datajoint-labbook/pharus/docker-compose-dev.yaml: services with 'depends_on' cannot be extended

Additional Research and Context

@guzman-raphael guzman-raphael added the enhancement New feature or request label Mar 31, 2021
@SPONGE-JL
Copy link

Is there anyone who track this issue?

@codytowstik
Copy link

It would be nice if it didn't throw an error, and just ignored the depends_on.

See this comment: docker/compose#3220 (comment)

@guzman-raphael
Copy link
Collaborator Author

Welcome @SPONGE-JL! Yes, our open-source team is tracking and we should be able to address this soon.

Thanks for the find @codytowstik! We have a new upcoming release of both Pharus and SciViz so we have a good opportunity to include a fix for this.

That said, if you have any suggestions, we welcome contributions and can certainly assist you in getting it patched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants