-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split item into multiple lines with correct markdown #8
Comments
@yarikoptic The reason we removed the wrapping was because, when the changelog entries were used in the body of a GitHub release, GitHub treats newlines in release bodies as hard breaks (the same as it does in issue & PR comments), so your sample wrapped text would show up as:
|
ha -- so points to the typo - added And indeed I now vaguely remember that suboptimal rendering for github releases. Have we discussed possibility to submit a desiire to Otherwise we would be doomed to either have quite suboptimally formatted github release entries or changelog entries, or I might be missing smth? (note: scriv itself uses CHANGELOG.rst not .md and somehow there is no such problem -- github releases look ok and changelog has them nicely paragraphed, so might me .md specific issue. Unless you see some reason, please clarify with |
No.
I think "dewarping" properly would require a full-fledged GitHub-Flavored Markdown parser, but one could probably handle 90%+ of cases with something like Scriv converts reStructuredText changelogs to Markdown for GitHub Releases using Pandoc with the |
well, may be the same |
@yarikoptic Even if it could, we wouldn't be able to apply that ourselves (if that's what you're suggesting) without either duplicating scriv's changelog-section-extraction or else editing the release notes after the release is created. |
I mean that we should suggest it to scriv in an issue describing current problem with formatted .md entries if posted like that to github release. |
@yarikoptic Feature request filed: nedbat/scriv#66 |
Echoing my question in nedbat/scriv#66 (comment) I think we should just do it (call pandoc on the found .md snippets) in this action code, unless you see some cons from doing that? It is ok for us to run time depend on pandoc. |
@yarikoptic You want to use pandoc with the |
Doh right! Dewarping really should be done by scriv, eh, let's forget about pretty GitHub release notes until scriv allowed y for them |
Blocked by nedbat/scriv#66. |
wrapping was removed since it was wrong but it is simple to just manually format it into multiple lines separating issues, prs and author like here https://github.com/datalad/datalad/pull/7084/files#diff-24339cbbf16b5fd0f274663820dcd77c38106994445a197aa748b79ebb3073f8R7
since single line is indeed too long/hard to grasp when looking at changelog
The text was updated successfully, but these errors were encountered: