Removed pdb/ipdb calls from API handlers (#243)

Author: asnytin

lib/dl_api_commons/dl_api_commons/aio/middlewares/error_handling_outer.py

@@ -67,7 +67,6 @@ def handle_error(
         elif isinstance(err, web.HTTPSuccessful):
             raise  # noqa
         else:
-            self.maybe_debug_catch(err)
             try:
                 # TODO CONSIDER: Validate that response is serializable
                 err_data = self._classify_error(err, request)
@@ -95,16 +94,6 @@ def handle_error(
                     err_data,
                 )
 
-    def maybe_debug_catch(self, err):  # type: ignore  # TODO: fix
-        if os.environ.get("BI_ERR_PDB"):
-            sys.last_traceback = err.__traceback__
-            import traceback
-
-            traceback.print_exc()
-            import ipdb
-
-            ipdb.pm()
-
     def log_error_http_response(  # type: ignore  # TODO: fix
         self,
         err: Exception,

lib/dl_api_commons/pyproject.toml

@@ -13,7 +13,6 @@ readme = "README.md"
 aiohttp = ">=3.8.1"
 attrs = ">=22.2.0"
 flask = ">=2.2.5"
-ipdb = ">=0.13.13"
 marshmallow = ">=3.19.0"
 multidict = ">=4.0"
 opentracing = ">=2.4.0"

lib/dl_api_lib/dl_api_lib/api_decorators.py

@@ -27,7 +27,6 @@
     status,
 )
 from dl_api_lib.schemas.main import get_api_model
-from dl_utils.utils import maybe_postmortem
 
 
 LOGGER = logging.getLogger(__name__)
@@ -153,7 +152,6 @@ def wrapper(*args, **kwargs):  # type: ignore  # TODO: fix
                 if error_code is None:
                     error_code = status.INTERNAL_SERVER_ERROR
                     LOGGER.exception("Caught an exception in request handler")
-                    maybe_postmortem(ei=ei)
                 else:
                     LOGGER.info("Regular exception fired", exc_info=True)
 

lib/dl_api_lib/dl_api_lib/app/data_api/resources/dataset/pivot.py

@@ -21,7 +21,6 @@
     generic_profiler_async,
 )
 from dl_query_processing.merging.primitives import MergedQueryDataStream
-from dl_utils.utils import exc_catch_awrap
 
 
 if TYPE_CHECKING:
@@ -49,7 +48,6 @@ class DatasetPivotView(DatasetDataBaseView):
     #     responses={200: ('Success', dl_api_lib.schemas.data.DatasetVersionResultResponseSchema())}
     # )
     @generic_profiler_async("ds-pivot-full")
-    @exc_catch_awrap
     @DatasetDataBaseView.with_resolved_entities
     @requires(RequiredResourceDSAPI.JSON_REQUEST)
     async def post(self) -> Response:

lib/dl_api_lib/dl_api_lib/app/data_api/resources/dataset/result.py

@@ -43,7 +43,6 @@
 )
 from dl_query_processing.merging.primitives import MergedQueryDataStream
 from dl_query_processing.postprocessing.primitives import PostprocessedRow
-from dl_utils.utils import exc_catch_awrap
 
 
 if TYPE_CHECKING:
@@ -68,7 +67,6 @@ class DatasetResultView(DatasetDataBaseView, abc.ABC):
     #     responses={200: ('Success', dl_api_lib.schemas.data.DatasetVersionResultResponseSchema())}
     # )
     @generic_profiler_async("ds-result-full")
-    @exc_catch_awrap
     @DatasetDataBaseView.with_resolved_entities
     @requires(RequiredResourceDSAPI.JSON_REQUEST)
     async def post(self) -> Response:

lib/dl_core/dl_core/connection_executors/async_sa_executors.py

@@ -46,7 +46,6 @@
 from dl_core.connection_models.common_models import TableDefinition
 from dl_core.db import SchemaInfo
 from dl_utils.aio import ContextVarExecutor
-from dl_utils.utils import maybe_postmortem
 
 
 if TYPE_CHECKING:

lib/dl_utils/dl_utils/utils.py

@@ -5,8 +5,6 @@
 import functools
 from itertools import islice
 import operator
-import os
-import sys
 from time import time
 from typing import (
     Any,
@@ -18,81 +16,11 @@
     Tuple,
     Type,
     TypeVar,
-    cast,
 )
 
 import attr
 
 
-def get_pdb() -> Any:
-    try:
-        import ipdb
-
-        return ipdb
-    except Exception:
-        import pdb
-
-        return pdb
-
-
-def maybe_postmortem(ei: Any = None) -> None:
-    """
-    An env-controlled post-mortem breakpoint.
-    Set `BI_ERR_PDB=1` to use.
-    """
-    if ei is None:
-        ei = sys.exc_info()
-    if os.environ.get("BI_ERR_PDB") != "1":
-        return
-    _, _, sys.last_traceback = ei
-    import traceback
-
-    print("".join(traceback.format_exception(*ei)))
-    pdb = get_pdb()
-    pdb.pm()
-
-
-_CALLABLE_TV = TypeVar("_CALLABLE_TV", bound=Callable)
-
-
-def exc_catch_wrap(func: _CALLABLE_TV) -> _CALLABLE_TV:
-    """
-    An env-controlled post-mortem function wrapper.
-    Set `BI_ERR_PDB=1` to use. Does nothing otherwise.
-    """
-    if os.environ.get("BI_ERR_PDB") != "1":
-        return func
-
-    @functools.wraps(func)
-    def exc_catch_wrapped(*args: Any, **kwargs: Any) -> Any:
-        try:
-            return func(*args, **kwargs)
-        except Exception:
-            maybe_postmortem()
-            raise
-
-    return cast(_CALLABLE_TV, exc_catch_wrapped)
-
-
-def exc_catch_awrap(afunc: _CALLABLE_TV) -> _CALLABLE_TV:
-    """
-    An env-controlled post-mortem async-function wrapper.
-    Set `BI_ERR_PDB=1` to use. Does nothing otherwise.
-    """
-    if os.environ.get("BI_ERR_PDB") != "1":
-        return afunc
-
-    @functools.wraps(afunc)
-    async def exc_catch_awrapped(*args: Any, **kwargs: Any) -> Any:
-        try:
-            return await afunc(*args, **kwargs)
-        except Exception:
-            maybe_postmortem()
-            raise
-
-    return cast(_CALLABLE_TV, exc_catch_awrapped)
-
-
 def get_type_full_name(t: Type) -> str:
     module = t.__module__
     qual_name = t.__qualname__