Skip to content

US client retries non-idempotent requests #249

@thenno

Description

@thenno

retry_methods={"GET", "POST", "PUT", "DELETE"}, # TODO: really retry all of them?..

Restarting POST requests to US is unsafe. I would suggest to remove POST from retry_methods.

Another strange thing is related to the codes:

self._retry_codes = {408, 429, 500, 502, 503, 504}
Retrying 408 and 429 is a way to completely shut down an overloaded service

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions