Skip to content

Commit 97cc708

Browse files
authored
Merge branch 'main' into CHARTS-11752
2 parents 2511c4a + d7490ad commit 97cc708

File tree

1 file changed

+10
-3
lines changed

1 file changed

+10
-3
lines changed

src/ui/components/FieldEditor/components/Settings.tsx

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ export const Settings: React.FC<SettingsProps> = ({
4646
isNewField,
4747
}) => {
4848
const inputRef = React.useRef<HTMLInputElement>(null);
49-
const [titleEditMode, setTitleEditMode] = React.useState(!title);
5049

5150
const {AdditionalButtonsWrapper} = registry.fieldEditor.components.getAll();
5251

@@ -77,6 +76,8 @@ export const Settings: React.FC<SettingsProps> = ({
7776
const errorMessageKey = getErrorMessageKey([DUPLICATE_TITLE, EMPTY_TITLE], errors);
7877
const showDocButton = isEnabledFeature(Feature.FieldEditorDocSection) && calcMode === 'formula';
7978

79+
const [titleEditMode, setTitleEditMode] = React.useState(!title || Boolean(errorMessageKey));
80+
8081
const handleStartEditTitle = React.useCallback(() => {
8182
setTitleEditMode(true);
8283
setTimeout(() => {
@@ -85,10 +86,16 @@ export const Settings: React.FC<SettingsProps> = ({
8586
}, []);
8687

8788
const handleStopEditTitle = React.useCallback(() => {
88-
if (inputTitle) {
89+
if (inputTitle && !errorMessageKey) {
8990
setTitleEditMode(false);
9091
}
91-
}, [inputTitle]);
92+
}, [inputTitle, errorMessageKey]);
93+
94+
React.useEffect(() => {
95+
if (errorMessageKey) {
96+
setTitleEditMode(true);
97+
}
98+
}, [errorMessageKey]);
9299

93100
return (
94101
<React.Fragment>

0 commit comments

Comments
 (0)