Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code in Mona is not the best #68

Open
5 of 8 tasks
nikitasakau opened this issue Dec 9, 2019 · 12 comments
Open
5 of 8 tasks

Code in Mona is not the best #68

nikitasakau opened this issue Dec 9, 2019 · 12 comments
Labels

Comments

@nikitasakau
Copy link
Member

nikitasakau commented Dec 9, 2019

  • Add Github actions
  • Add ESLint
  • Check and merge dependencies' PRs
  • Update README with actual information and dev tips
  • Remove .DS_Store from gitignore, because it's related to local machine, not project
  • bot.js file is overwhelming, need to split into helpers?, maybe separate file for each action?
  • All files should be named with camelCase, not snake_case
  • Think about specs refactoring #61 Think about tests refactoring
@lazycoder9
Copy link
Contributor

lazycoder9 commented Dec 9, 2019

I don't like module.exports and require in code. I prefer to use import/export syntax. I suggest that we can use latest node on heroku to use this syntax. I can make some investigation if it is possible to use latest node in heroku

@lazycoder9
Copy link
Contributor

use the engines section of your package.json to specify the version of Node.js to use on Heroku. Drop the ‘v’ to save only the version number:

{
  "name": "myapp",
  "description": "a really cool app",
  "version": "1.0.0",
  "engines": {
    "node": "12.13.0"
  }
}

@lazycoder9
Copy link
Contributor

I was able to use import and export in code with Node v13.2 locally

@lazycoder9
Copy link
Contributor

@npupko @nikitasakov what do you think about setting up Github actions? Sounds reasonable if you want to set up linter too

@npupko
Copy link
Member

npupko commented Dec 9, 2019

@lazycoder9 Is it (setup) faster than other CI services?
How much time will we need to enable it from scratch?
Didn't work with it before.

@lazycoder9
Copy link
Contributor

@npupko it took me about 30 minutes to learn about it and 5 minutes to implement it in docker_benchmark repo 😄

@npupko
Copy link
Member

npupko commented Dec 9, 2019

@lazycoder9 This is what we need then:)

@AleksSenkou
Copy link
Contributor

Gyus, I'd suggest keeping a checklist in issue's description to know what is left, easier to manage

All of you should have access to edit the description 😉

@npupko
Copy link
Member

npupko commented Dec 9, 2019

Dudes, how about using yarn instead of npm?

@lazycoder9
Copy link
Contributor

@npupko @nikitasakov Also, I want to move from mocha to jest. Thoughts?

@npupko
Copy link
Member

npupko commented Dec 9, 2019

@lazycoder9 Mocks out of the box and rspec-similar syntax. I like it.
But is it worth the time?

@lazycoder9
Copy link
Contributor

@npupko refreshed my knowledge about jest yesterday and I don't think that it is worth our effort currently to move to jest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants