Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It responds with greeting when people say hi to others #82

Open
ezhlobo opened this issue Feb 9, 2020 · 2 comments · Fixed by #83 · May be fixed by #87
Open

It responds with greeting when people say hi to others #82

ezhlobo opened this issue Feb 9, 2020 · 2 comments · Fixed by #83 · May be fixed by #87
Assignees
@nikitasakau

Comments

@ezhlobo
Copy link
Member

ezhlobo commented Feb 9, 2020

I believe Mona should respond to greetings only if none was mentioned.

Screen Shot 2020-02-09 at 13 37 40
@nikitasakau nikitasakau self-assigned this Mar 6, 2020
@nikitasakau
Copy link
Member

nikitasakau commented Mar 6, 2020 •
edited
Loading

I think that Mona should ignore greetings:

  • from not general channels
  • when somebody else mentioned
  • in threads

Working on it

@nikitasakau nikitasakau mentioned this issue Mar 9, 2020
Merged
@nikitasakau
Copy link
Member

nikitasakau commented Mar 11, 2020 •
edited
Loading

As it turned out slack use another way for @here, @channel, etc mentions.

For users it is <@***>. For @here it is <!***>. So need to forbid to answer in these cases too

image

@nikitasakau nikitasakau reopened this Mar 11, 2020
@nikitasakau nikitasakau linked a pull request Oct 2, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikitasakau nikitasakau

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ezhlobo @nikitasakau