From 6de9d239e5c92aaee10c1e69bfbc4c25939cc510 Mon Sep 17 00:00:00 2001
From: Sam Morley <admin@inakleinbottle.com>
Date: Tue, 26 Nov 2024 14:54:48 +0000
Subject: [PATCH] Fix unreachable return warning in comparison trait

Update RPY_UNREACHABLE_RETURN to return false instead of void to eliminate unreachable return warning in the ComparisonTraitImpl class. This ensures compliance with modern compiler standards and improves code robustness.
---
 platform/include/roughpy/generics/comparison_trait.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/platform/include/roughpy/generics/comparison_trait.h b/platform/include/roughpy/generics/comparison_trait.h
index f5e0b71a..8cdd60f8 100644
--- a/platform/include/roughpy/generics/comparison_trait.h
+++ b/platform/include/roughpy/generics/comparison_trait.h
@@ -340,7 +340,7 @@ bool ComparisonTraitImpl<T>::has_comparison(ComparisonType comp) const noexcept
             return dtl::has_greater_equal_test_v<T>
                     || (dtl::has_greater_test_v<T> && dtl::has_equal_test_v<T>);
     }
-    RPY_UNREACHABLE_RETURN();
+    RPY_UNREACHABLE_RETURN(false);
 }
 template <typename T>
 bool ComparisonTraitImpl<T>::unsafe_compare_equal(