Some more improvements

Author: puehringer

packages/angular-table/tsconfig.build.json

@@ -4,7 +4,9 @@
     "allowJs": true,
     "module": "ESNext",
     "moduleDetection": "force",
-    "moduleResolution": "Bundler"
+    "moduleResolution": "Bundler",
+    // Use a more recent lib to support ES2022 features, because we now use the index.ts as entrypoint for table-core
+    "lib": ["dom", "es2022"]
   },
   "angularCompilerOptions": {
     "enableI18nLegacyMessageIdFormat": false,

packages/table-core/src/core/row.ts

@@ -114,22 +114,30 @@ export function getRowProto<TData extends RowData>(table: Table<TData>) {
     proto.subRows = [] as const
 
     proto.getValue = function (columnId: string) {
+      /*
       if (this._valuesCache.hasOwnProperty(columnId)) {
         return this._valuesCache[columnId]
       }
+      */
 
       const column = table.getColumn(columnId)
 
       if (!column?.accessorFn) {
         return undefined
       }
 
+      return column.accessorFn(
+        this.original as TData,
+        this.index
+      ) as any
+      /*
       this._valuesCache[columnId] = column.accessorFn(
         this.original as TData,
         this.index
       )
 
       return this._valuesCache[columnId] as any
+      */
     }
 
     proto.getUniqueValues = function (columnId: string) {
@@ -149,8 +157,10 @@ export function getRowProto<TData extends RowData>(table: Table<TData>) {
       }
 
       if (!column.columnDef.getUniqueValues) {
-        this._uniqueValuesCache[columnId] = [this.getValue(columnId)]
-        return this._uniqueValuesCache[columnId]
+        // Avoid unnecessary caching for unique values
+        return [this.getValue(columnId)];
+        // this._uniqueValuesCache[columnId] = [this.getValue(columnId)]
+        // return this._uniqueValuesCache[columnId]
       }
 
       this._uniqueValuesCache[columnId] = column.columnDef.getUniqueValues(
@@ -199,16 +209,20 @@ export function getRowProto<TData extends RowData>(table: Table<TData>) {
 
     proto._getAllCellsByColumnId = memo(
       function (this: Row<TData>) {
-        return [this.getAllCells()]
+        // return [this.getAllCells()]
+        return []
       },
-      allCells => {
+      () => {
+        throw new Error('Row._getAllCellsByColumnId not implemented because it is a memory leak')
+        /*
         return allCells.reduce(
           (acc, cell) => {
             acc[cell.column.id] = cell
             return acc
           },
           {} as Record<string, Cell<TData, unknown>>
         )
+        */
       },
       getMemoOptions(table.options, 'debugRows', 'getAllCellsByColumnId')
     )
@@ -236,7 +250,7 @@ export const createRow = <TData extends RowData>(
     original,
     depth,
     parentId,
-    _valuesCache: {},
+    // _valuesCache: {},
   })
 
   if (subRows) {

packages/table-core/src/utils/getFilteredRowModel.ts

@@ -18,11 +18,15 @@ export function getFilteredRowModel<TData extends RowData>(): (
           !rowModel.rows.length ||
           (!columnFilters?.length && !globalFilter)
         ) {
+          // TODO: Does this have any consequences? Would avoid iterating the rows again
+          return rowModel;
+          /*
           for (let i = 0; i < rowModel.flatRows.length; i++) {
             rowModel.flatRows[i]!.columnFilters = {}
             rowModel.flatRows[i]!.columnFiltersMeta = {}
           }
           return rowModel
+          */
         }
 
         const resolvedColumnFilters: ResolvedColumnFilter<TData>[] = []

packages/table-core/src/utils/getGroupedRowModel.ts

@@ -11,11 +11,15 @@ export function getGroupedRowModel<TData extends RowData>(): (
       () => [table.getState().grouping, table.getPreGroupedRowModel()],
       (grouping, rowModel) => {
         if (!rowModel.rows.length || !grouping.length) {
+          // TODO: Does this have any consequences? Would avoid iterating the rows again
+          return rowModel;
+          /*
           rowModel.rows.forEach(row => {
             row.depth = 0
             row.parentId = undefined
           })
           return rowModel
+          */
         }
 
         // Filter the grouping list down to columns that exist