Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

template: add lookup support #2313

Merged
merged 10 commits into from
Nov 27, 2024
Merged

template: add lookup support #2313

merged 10 commits into from
Nov 27, 2024

Commits on Nov 26, 2024

  1. docs: document load_lookup_table

    @jqnatividad
    jqnatividad committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    a96d5d7 View commit details
    Browse the repository at this point in the history

  2. feat: add lookup support to template command

    @jqnatividad
    jqnatividad committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    4166b9f View commit details
    Browse the repository at this point in the history

  3. tests: add template lookup tests

    @jqnatividad
    jqnatividad committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    ee9a4a7 View commit details
    Browse the repository at this point in the history

  4. tests: make template test platform-independent

    @jqnatividad
    jqnatividad committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    7f226e0 View commit details
    Browse the repository at this point in the history

  5. refactor: add case-sensitive arg to lookup filter; more verbose looku… 

    …p error messages
    @jqnatividad
    jqnatividad committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    91a7f19 View commit details
    Browse the repository at this point in the history

  6. test: lookup case sensitivity tests

    @jqnatividad
    jqnatividad committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    73466b2 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2024

  1. refactor: add rowcount to LookupTableResult struct 

    so we can use it to prealloc Hashmap in template, for better memory allocation and cache locality
    @jqnatividad
    jqnatividad committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    159c051 View commit details
    Browse the repository at this point in the history

  2. refactor: changed LookupMap data structure 

    from HashSet<Vec(String, String)> to a nested Hashmap which is both more memory efficient and faster (O(1) vs O(n))
    @jqnatividad
    jqnatividad committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    81753cd View commit details
    Browse the repository at this point in the history

  3. tests: updated template lookup tests

    @jqnatividad
    jqnatividad committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    b7ecd33 View commit details
    Browse the repository at this point in the history

  4. deps: update lock file

    @jqnatividad
    jqnatividad committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    4ac4b95 View commit details
    Browse the repository at this point in the history