Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] It would be cool if Rofi is able to play sounds like a game menu. #2032

Open
2 tasks done
its-19818942118 opened this issue Sep 21, 2024 · 8 comments
Open
2 tasks done

Comments

@its-19818942118
Copy link

its-19818942118 commented Sep 21, 2024

Before opening a feature request

  • I searched existing reports to see if it is already requested.
  • I checked the next branch to see if the feature has already been implemented

What is the user problem or growth opportunity you want to see solved?

well. personally for me i think it would be really cool if rofi had sound support (sfx). just like a game menu. i think it increases the overall look and feel of it. and most importantly it sounds fun. 😄

How do you know that this problem exists today? Why is this important?

this isnt particularly an issue. but just a UI/UX feat. 😅 . and i belive it is possible to use sounds to read out the contents of the menu etc. it can be really handy in some cases.
personally for me, i just wanted a game menu like experience. i have solved the opening and closing issue of rofi via scripts. but unable to solve for entry selection. entry choice etc.

Who will benefit from it?

i belive that everyone could benefit from it. generally speaking an interactive like game menu ish sounding rofi is nice. and i belive a lot of stuff can be made useful using this. like embedding a translator for example with sound support?

Rofi version (rofi -v)

Version: 1.7.5+wayland3

Configuration

https://gist.github.com/its-19818942118/769e5d1ace9d473ec3a83ed8a1913768

Additional information

Sound playback for the following:

  • sound on startup and close event
  • sound on click input event
  • sound on mode change event
  • change selection (e.g. selection-changed event)
  • sounds when you type into the entry box? input, backspace etc (filter-changed event)
  • Or when you hit return on a row? (accept event)
  • Sound on input error, search error, failed input
  • sound on hover correspondence to its keyboard counter parts. example entries.
  • sound on moving around and focus change .
  • sounds on app startup via rofi drun. to execute the sound. (app close, dk if it's possible so not a priority).
@giomatfois62
Copy link
Contributor

I thought about asking the same some time ago, then I forgot xD
Will try to make some prototype if I have some free time

@its-19818942118
Copy link
Author

@giomatfois62 thanks 😄

@DaveDavenport
Copy link
Collaborator

I am not sure what is actually requested here? when do you want rofi to make sound?

  • If you change selection (e.g. selection-changed event)
  • sounds when you type into the entry box? (filter-changed event)
  • Or when you hit return on a row? (accept event)
    What data is required to play the sound?

Could we write this down in a more 'specification' way?

I am not sure if rofi should be playing sounds? but maybe we can bind execution of an external program to events (that allows you to play sound.) giving a more generic solution.

@its-19818942118
Copy link
Author

I am not sure what is actually requested here? when do you want rofi to make sound?

  • If you change selection (e.g. selection-changed event)
  • sounds when you type into the entry box? (filter-changed event)
  • Or when you hit return on a row? (accept event)
    What data is required to play the sound?

Could we write this down in a more 'specification' way?

I am not sure if rofi should be playing sounds? but maybe we can bind execution of an external program to events (that allows you to play sound.) giving a more generic solution.

@DaveDavenport
Well I have done that alternate solution using a bash scripts. Using keybindings but that's as far as it goes. For rofi a startup sound was possible via launch script but again that's about it.
And yes all of the above. I will umm do a more wide description. I thought since I mentioned a game menu I wouldn't have to clarify further 😅

@DaveDavenport
Copy link
Collaborator

DaveDavenport commented Oct 2, 2024

I thought since I mentioned a game menu I wouldn't have to clarify further 😅

I am very confused and do not understand this remark. How is 'game menu' a clear description (on sounds playback support)?

@its-19818942118
Copy link
Author

I thought since I mentioned a game menu I wouldn't have to clarify further 😅

I am very confused and do not understand this remark. How is 'game menu' a clear description (on sounds playback support)?

well i thought it would imply like that as gmae menus do play sounds in such events. my bad for assuming it 😅 . will be updating it now. thanks for pointing this out 👍

@DaveDavenport
Copy link
Collaborator

DaveDavenport commented Oct 3, 2024

Not being a fanatic gamer and most games I play not having sound in menus (and me not even turning sound on), its not clear (hence my ask for clarification).

for example:

  • Do you play on input, even if the input does not cause a state change? or play an error sound to indicate input failed to make a change. (is this the same for most games?)
  • Do you play sound on moving around, or only on an actual action (like entering new characters, or selecting item)?
    etc.

These things kinda need to be clear to make an implementation.

@its-19818942118
Copy link
Author

its-19818942118 commented Oct 5, 2024

Not being a fanatic gamer and most games I play not having sound in menus (and me not even turning sound on), its not clear (hence my ask for clarification).

for example:

  • Do you play on input, even if the input does not cause a state change? or play an error sound to indicate input failed to make a change. (is this the same for most games?)
  • Do you play sound on moving around, or only on an actual action (like entering new characters, or selecting item)?
    etc.

These things kinda need to be clear to make an implementation.

@DaveDavenport thanks for the clarification I have added on what events sounds should be added. And personally I have never played games too. I apologize for assuming that it would be understandable but it seems a mistake on my part. I will update accordingly. I am really sorry for not being able to explain it well. Pls let me know if further clarification is required 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants