Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reserve returns 404 although a node is reserved #6

Open
pjanouse opened this issue Jun 6, 2017 · 6 comments
Open

reserve returns 404 although a node is reserved #6

pjanouse opened this issue Jun 6, 2017 · 6 comments

Comments

@pjanouse
Copy link

pjanouse commented Jun 6, 2017

Method reserve returns 404 as a reaction for HTML output even a node is reserved.

I'm not an expert on Ruby, but I guess, this line of code needs a fix, it should be format.html { render :json => hosts } as in other methods.

@eedri
Copy link
Collaborator

eedri commented Jun 6, 2017

Hi,
Unfortunately, this plugin in not maintained anymore.
If you use it, I can give you admin rights to merge any fix you see fit.

@pjanouse
Copy link
Author

pjanouse commented Jun 6, 2017

Hi Eyal,
I'm aware of the state of this project, unfortunately I've inherited one project where this is a dependency. So I have to deal with it...

It would be nice to grant me the rights to be able to merge at least one fix - PR #7

Can you review the fix please?

@eedri
Copy link
Collaborator

eedri commented Jun 6, 2017

It looks like I don't have rights to merge as well, @david-caro who is the original maintainer can do it and also assign you admin rights.

But maybe its best if you fork the project to your own user and continue development there?

@pjanouse
Copy link
Author

pjanouse commented Jun 6, 2017

I had done that before PR created.

@david-caro
Copy link
Owner

I'll give you rights to the repo (both, @eedri and @pjanouse), though as @eedri says, the repo is unmantqined, so if you want to maintain it, might be nicer to add a note in this one pointing to your fork.

@david-caro
Copy link
Owner

I just gave you access to the repo, let me know if you need anything else 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants