Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in test of HOLE 2 #5

Open
madewael opened this issue Dec 3, 2024 · 0 comments
Open

Error in test of HOLE 2 #5

madewael opened this issue Dec 3, 2024 · 0 comments

Comments

@madewael
Copy link

madewael commented Dec 3, 2024 •
edited
Loading

Dear

During the transition of java8 -> 21, and Junit4->5 an error was introduced in
https://github.com/daviddenton/refactoring-golf/blame/master/hole2/src/test/java/hole2/TakeHomeCalculatorTest.java

The test imports class Incalculable extends RuntimeException"from HOLE 1, cause the tests to fail.
Simply removing line 4, removes the issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@madewael