From 577efff16b503a5f88126f2c5d26b7c4139e95d0 Mon Sep 17 00:00:00 2001
From: David Festal <dfestal@redhat.com>
Date: Tue, 30 Apr 2024 20:43:35 +0200
Subject: [PATCH] fix(cli): remove the requirement for `app-config` when
 exporting fronted plugins to dynamic. (#1592)

Signed-off-by: David Festal <dfestal@redhat.com>
---
 packages/cli/src/lib/bundler/bundlePlugin.ts   | 2 --
 packages/cli/src/lib/bundler/scalprumConfig.ts | 1 -
 packages/cli/src/lib/bundler/types.ts          | 3 ---
 3 files changed, 6 deletions(-)

diff --git a/packages/cli/src/lib/bundler/bundlePlugin.ts b/packages/cli/src/lib/bundler/bundlePlugin.ts
index cf20f446d4..f1cdc66e66 100644
--- a/packages/cli/src/lib/bundler/bundlePlugin.ts
+++ b/packages/cli/src/lib/bundler/bundlePlugin.ts
@@ -9,7 +9,6 @@ import fs from 'fs-extra';
 import webpack from 'webpack';
 import yn from 'yn';
 
-import { resolveBaseUrl } from './config';
 import { BundlingPathsOptions, resolveBundlingPaths } from './paths';
 import { createScalprumConfig } from './scalprumConfig';
 import { DynamicPluginOptions } from './types';
@@ -38,7 +37,6 @@ export async function buildScalprumBundle(
       ...options,
       checksEnabled: false,
       isDev: false,
-      baseUrl: resolveBaseUrl(options.frontendConfig),
     },
   );
 
diff --git a/packages/cli/src/lib/bundler/scalprumConfig.ts b/packages/cli/src/lib/bundler/scalprumConfig.ts
index de79dd6e0c..aee286058c 100644
--- a/packages/cli/src/lib/bundler/scalprumConfig.ts
+++ b/packages/cli/src/lib/bundler/scalprumConfig.ts
@@ -107,7 +107,6 @@ export async function createScalprumConfig(
   plugins.push(
     new webpack.EnvironmentPlugin({
       HAS_REACT_DOM_CLIENT: false,
-      APP_CONFIG: options.frontendAppConfigs,
     }),
   );
 
diff --git a/packages/cli/src/lib/bundler/types.ts b/packages/cli/src/lib/bundler/types.ts
index c69e4a2ff2..e0f9720310 100644
--- a/packages/cli/src/lib/bundler/types.ts
+++ b/packages/cli/src/lib/bundler/types.ts
@@ -34,9 +34,6 @@ export type BundlingOptions = {
 export type DynamicPluginOptions = {
   checksEnabled?: boolean;
   isDev?: boolean;
-  frontendConfig: Config;
-  frontendAppConfigs: AppConfig[];
-  baseUrl?: URL;
   parallelism?: number;
   pluginMetadata: PluginBuildMetadata;
 };