fix: targetting and add shape to ndarray #891
Open
+41
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add documentation for cylinder targetting. fix minor typos in documentations
Helveg
approved these changes
Oct 4, 2024
bsb/config/types.py
Outdated
Comment on lines
797
to
802
| if shape is not None: | ||
| for dim in shape: | ||
| if dim < 0: | ||
| raise TypeError( | ||
| f"Ndarray shape must all be positive. Provided {shape}." | ||
| ) |
There was a problem hiding this comment.
Suggested change
| if shape is not None: | |
| for dim in shape: | |
| if dim < 0: | |
| raise TypeError( | |
| f"Ndarray shape must all be positive. Provided {shape}." | |
| ) | |
| if (shape or ()).any(lambda dim: dim < 0): | |
| raise TypeError( | |
| f"types.ndarray shape must all be positive. Provided {shape}." | |
| ) |
There was a problem hiding this comment.
tuple does not have an any function but I kept the concept in my last commit.
bsb/config/types.py
Outdated
| result = result.reshape(self.shape) | ||
| except Exception: | ||
| raise TypeError( | ||
| "Couldn't cast {} into an array of shape {}".format(value, self.shape) |
There was a problem hiding this comment.
Isn't this going to give a really big message for really big arrays?
Suggested change
| "Couldn't cast {} into an array of shape {}".format(value, self.shape) | |
| f"Couldn't cast array of {getattr(value, 'shape', 'unknown')} shape into an array of {self.shape} shape." |
Always prefer f-strings over .format
There was a problem hiding this comment.
hmm value might not be a ndarray but we can assume that it is
There was a problem hiding this comment.
oh true, let me correct that
There was a problem hiding this comment.
implemented in my last commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the work done
List which issues this resolves:
closes #890, #869
Tasks