Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParallelArrayPlacement does not work if the partition origin is not [0, 0, 0] #889

Open
drodarie opened this issue Sep 26, 2024 · 0 comments · May be fixed by #886
Open

ParallelArrayPlacement does not work if the partition origin is not [0, 0, 0] #889

drodarie opened this issue Sep 26, 2024 · 0 comments · May be fixed by #886
Assignees
Labels
bug Something isn't working

Comments

@drodarie
Copy link
Contributor

drodarie commented Sep 26, 2024

network:
  chunk_size: [100, 100, 100]
  x: 300
  y: 300
  z: 100
regions:
  cerebellar_cortex:
    type: group
    children:
      - purkinje_layer
partitions:
  purkinje_layer:
    type: rhomboid
    origin: [150, 150, 0]
    dimensions: [150, 150, 15]
cell_types:
  purkinje_cell:
    spatial:
      morphologies:
        - PurkinjeCell
      planar_density: 0.00045
      radius: 7.5
    plotting:
      display_name: Purkinje cell
placement:
  purkinje_layer_placement:
    strategy: bsb.placement.ParallelArrayPlacement
    partitions:
      - purkinje_layer
    cell_types:
      - purkinje_cell
    spacing_x: 130
    angle: 70

this configuration results in no cells placed whereas if the origin was at 0, it would have been ~13 cells.
this happens during the placement, probably because of line 86 in file bsb.placement.arrays.py:

positions = cells[cells[:, 0] < width - radius]

should be something along this line

positions = cells[cells[:, 0] < prt.data.ldc[0] + width - radius]
@drodarie drodarie added the bug Something isn't working label Sep 26, 2024
@drodarie drodarie self-assigned this Sep 26, 2024
@drodarie drodarie linked a pull request Oct 1, 2024 that will close this issue
1 task
@drodarie drodarie linked a pull request Oct 3, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant