Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: multimeter #4

Closed
drodarie opened this issue Mar 19, 2024 · 6 comments · Fixed by #5
Closed

Feature request: multimeter #4

drodarie opened this issue Mar 19, 2024 · 6 comments · Fixed by #5
Assignees

Comments

@drodarie
Copy link
Contributor

As a user, I need to record neurons' membrane potential during Nest simulation with bsb. This corresponds to the multimeter tool in Nest.

@Helveg
Copy link
Contributor

Helveg commented Mar 19, 2024

The default bsb-nest device is the external device which defers directly to NEST:

my_multi:
  nest_model: multimeter
  constants:
    whatever: params
    nest: needs

@Helveg Helveg closed this as completed Mar 19, 2024
@Helveg
Copy link
Contributor

Helveg commented Mar 19, 2024

But PRs are always welcome for specific devices if they offer advantages over using NEST devices!

@Helveg
Copy link
Contributor

Helveg commented Mar 19, 2024

Actually after looking at dbbs-lab/bsb-core#67, I think there's a lot of room to improve the UX with a dedicated multimeter device. For example, the recordings of a multimeter ought to be added to the results file, and a lot of metadata should be tracked. Would you be willing to look into this @drodarie if I walked you through it?

@drodarie
Copy link
Contributor Author

Sure! I am drafting a Multimeter extending NestDevice, inspiring myself from the SpikeRecorder class. I still need to test it though.

@drodarie
Copy link
Contributor Author

drodarie commented May 2, 2024

See PR #5 related to this issue

@drodarie drodarie self-assigned this May 2, 2024
@Helveg Helveg linked a pull request May 2, 2024 that will close this issue
@Helveg
Copy link
Contributor

Helveg commented May 2, 2024

(You can linked issues to PRs from the PR:

image

)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants