You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently completion works well (or so I think!) in queries that are being typed out.
However there is one issue I have encountered - say:
You connect to a database: DbMetadata object gets a list of catalogs as the connection is immediately expanded.
You recall a query from history SELECT * FROM AdventureWorks2017.Person.Address
Auto complete works fine if you were to, for example expand the query with ... WHERE.
However if you were to erase from the end and try and reach a different table within the AdventureWorks2017.Person schema completion would come up blank since at that point it hasn't enumerated the schema within the AdventureWorks2017 catalog. (DbMetadata returns None, which is a signal to the completer that this is not a valid catalog.schema combination)
One possible solution - prior to returning None, perhaps DbMetadata should check if AdventureWorks2017 has been listed at all.
Long term solution is that all the extend_* calls should be taken out of the completer and brought inside DbMetadata so that we can house all the logic of the form if not found then query in one place.
The text was updated successfully, but these errors were encountered:
Currently completion works well (or so I think!) in queries that are being typed out.
However there is one issue I have encountered - say:
DbMetadata
object gets a list of catalogs as the connection is immediately expanded.SELECT * FROM AdventureWorks2017.Person.Address
... WHERE
.AdventureWorks2017.Person
schema completion would come up blank since at that point it hasn't enumerated the schema within theAdventureWorks2017
catalog. (DbMetadata
returns None, which is a signal to the completer that this is not a validcatalog.schema
combination)One possible solution - prior to returning
None
, perhapsDbMetadata
should check ifAdventureWorks2017
has been listed at all.Long term solution is that all the
extend_*
calls should be taken out of the completer and brought insideDbMetadata
so that we can house all the logic of the formif not found then query
in one place.The text was updated successfully, but these errors were encountered: