-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug with manifest on onFragment #291
Comments
Hey :) |
I just published 0.3.8 on npm, can you check if it fixes your problem? |
Hey @jbaiter :) Yes it fixed the plugin issue but the code seems to be the same in the original mirador.js code (see the dirty fix I have to deploy: https://github.com/PonteIneptique/htr-light-viz-action/blob/main/dirty-fix.py ) This might be due to a parsing issue, or an ALTO having an incorrect line ? |
Can you give me a sample ALTO that fails due to this bug? |
I am gonna try to set up an example by next week, I am in slow mode since a couple of days and I am trying to get back in the game ^^ |
Hi there :)
I have been playing with the plugin in the last day, and something failed, probably because of a bad ALTO but I have stopped javascript for too long to be able to pinpoint more than a specific issue, which is IIIF-Commons/manifesto#121
Basically, there seems to be an issue with Fragment, which could be caused downstream of this plugin or downstream of manifesto. I wanted you to know this :)
The text was updated successfully, but these errors were encountered: