Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow base model creation to take multiple tables as arguments #233

Closed
Eromtap opened this issue Dec 4, 2024 · 3 comments · May be fixed by #225
Closed

Allow base model creation to take multiple tables as arguments #233

Eromtap opened this issue Dec 4, 2024 · 3 comments · May be fixed by #225
Labels

Comments

@Eromtap
Copy link

Eromtap commented Dec 4, 2024

Describe the feature

In my workflow, it is often necessary to copy multiple tables from one schema to another. The base model creation feature in DBT codegen has been awesome, but I altered it to accept more than one table arg at a time. According to the docs, it should have been able to accept multiple args before, but it wouldn't work and I didn't see any iterative logic in bash_scripts/base_model_creation.sh so I added it.

Additional context

I sent a PR ( #225 ) with the changes and was asked to provide a feature request here.

Who will this benefit?

Anyone who needs to generate copies of multiple tables. In my case, my company is moving to a different form of ingest that is requiring copying entire schemas over table by table.

Are you interested in contributing this feature?

I would love to contribute! DBT and Codegen have been game changers and I'd be honored to be a contributor!!!

@Eromtap Eromtap added enhancement New feature or request triage labels Dec 4, 2024
@dbeatty10 dbeatty10 changed the title Base model creation only takes one table as an arguement Allow base model creation to take multiple tables as arguments Dec 5, 2024
@dbeatty10
Copy link
Contributor

This sounds good to me as long as it is backwards-compatible. i.e., if a command like the following still works:

dbt run-operation codegen.create_base_models --args '{"source_name": "dbt_dbeatty", "tables": ["raw_orders", "raw_customers", "asdfasdf"]}'

Could you check to see if this would still work or not?

Copy link

github-actions bot commented Mar 6, 2025

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Mar 6, 2025
Copy link

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants