Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] dbt -v doesn't know that adapters are decoupled from core #10230

Open
2 tasks done
joellabes opened this issue May 28, 2024 · 3 comments · May be fixed by #10919
Open
2 tasks done

[Bug] dbt -v doesn't know that adapters are decoupled from core #10230

joellabes opened this issue May 28, 2024 · 3 comments · May be fixed by #10919
Assignees
@QMalcolm
Labels
bug Something isn't working Medium Severity bug with minor impact that does not have resolution timeframe requirement
Milestone
v1.9

Comments

@joellabes
Copy link
Contributor

Is this a new bug in dbt-core?

  • I believe this is a new bug in dbt-core
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

I installed dbt-core from the main branch, and ran dbt -v.

I got this output:

(dbt-dev) joel@Joel-Labes dbt-audit-helper % dbt -v
Core:
  - installed: 1.9.0-a1
  - latest:    1.8.1    - Ahead of latest version!

Plugins:
  - snowflake: 1.8.2   - Not compatible!
  - postgres:  1.9.0a1 - Ahead of latest version!

  At least one plugin is out of date or incompatible with dbt-core.
  You can find instructions for upgrading here:
  https://docs.getdbt.com/docs/installation

Expected Behavior

As of 1.8, the fact that the Snowflake adapter has a different minor version isn't a problem. dbt run etc works fine, it's just the warnings that are coming from the version checking code.

Steps To Reproduce

Install a version of dbt calling itself 1.9 alongside a 1.8 vintage of an adapter
run dbt -v

Relevant log output

No response

Environment

- OS: 
- Python:
- dbt: 1.9.0-a1

Which database adapter are you using with dbt?

No response

Additional Context

No response
@joellabes joellabes added bug Something isn't working triage labels May 28, 2024
@dbeatty10 dbeatty10 added Medium Severity bug with minor impact that does not have resolution timeframe requirement and removed triage labels May 28, 2024
@dbeatty10
Copy link
Contributor

Thanks for reporting this @joellabes 👍

Acceptance criteria

  1. If dbt-core is >= 1.8.0 and the adapter version is >= 1.8.0, then the output should not include "Not compatible!"
  2. If dbt-core is >= 1.8.0 and the adapter version is < 1.8.0, then the output should include "Not compatible!"
  3. If dbt-core is < 1.8.0 and the adapter version is not the same minor version, then the output should include "Not compatible!"
$ dbt --version

Core:
  - installed: 1.9.0
  - latest:    1.9.1

Plugins:
  - snowflake: 1.8.2

@dataders
Copy link
Contributor

Just experienced the same thing

This is due to the plugin.minor != core.minor comparison:

dbt-core/core/dbt/version.py

Lines 130 to 133 in 014444d

if plugin.major != core.major or plugin.minor != core.minor:
compatibility_msg = red("Not compatible!")
needs_update = True
return (compatibility_msg, needs_update)

@dataders dataders mentioned this issue Jul 31, 2024
Closed
2 tasks
@graciegoheen graciegoheen added this to the v1.9 milestone Jul 31, 2024
@ChenyuLInx
Copy link
Contributor

Talked during estimation, we could just not report incompatible in this case.

@dave-connors-3 dave-connors-3 linked a pull request Oct 25, 2024 that will close this issue
Open
5 tasks
@joellabes joellabes mentioned this issue Nov 11, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@QMalcolm QMalcolm

Labels
bug Something isn't working Medium Severity bug with minor impact that does not have resolution timeframe requirement
Projects
None yet
Milestone
v1.9
Development

Successfully merging a pull request may close this issue.

update adapter version messages dbt-labs/dbt-core
6 participants
@joellabes @dataders @QMalcolm @ChenyuLInx @dbeatty10 @graciegoheen