Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] use redshift_connector for metadata wherever possible #776

Closed
3 tasks done
dataders opened this issue Apr 19, 2024 · 2 comments
Closed
3 tasks done

[Feature] use redshift_connector for metadata wherever possible #776

dataders opened this issue Apr 19, 2024 · 2 comments
Labels
enhancement New feature or request Stale

Comments

@dataders
Copy link
Contributor

dataders commented Apr 19, 2024

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt-redshift functionality, rather than a Big Idea better suited to a discussion

Describe the feature

Wherever possible, fully rely on redshift driver for metadata and not SQL info_schema or any postgres system view like pg_*.

This will future-proof the adapter as well as unblock robust support for Datasharing (see #742)

Exhaustive list of related issues and PRs (so far)

Throughout the process, we may discover shortcomings in the driver. As @ryanwaldof says in #742:

If this isn't possible because our APIs don't support your use cases lets chat so we can figure out how to fix this. If we need to provide more info in our APIs, we need to provide more info in our APIs.

In these circumstances, migration to driver for metadata would pause while the driver adds the required information.

Additionally, it is crucially important that these changes are sufficiently tested and performance is considered.

One idea that @colin-rogers-dbt and I discussed was that these metadata-related changes might be merged into a feature branch for longer-term testing with customers before merging and releasing as a new minor version of dbt-redshift.

related issues

Describe alternatives you've considered

No response

Who will this benefit?

No response

Are you interested in contributing this feature?

No response

Anything else?

No response

Copy link
Contributor

github-actions bot commented Nov 7, 2024

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 7, 2024
Copy link
Contributor

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Stale
Projects
None yet
Development

No branches or pull requests

1 participant