Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dbt-postgres dependency #840

Closed
wants to merge 12 commits into from
Closed

Conversation

mikealfare
Copy link
Contributor

resolves #811

Problem

dbt-redshift depends on dbt-postgres for a very small number of macros, and no python code. This is a large dependency for minimal convenience. This recently caused issues, like the psycopg2 install. It also makes it a little harder to remove dependencies on things like pg_% tables.

Solution

  • remove the dependency on dbt-postgres
  • vendor referenced macros into dbt-redshift
  • ensure tests still complete successfully.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Jun 5, 2024
@cla-bot cla-bot bot added the cla:yes label Jun 5, 2024
Copy link
Contributor

github-actions bot commented Jun 5, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-redshift contributing guide.

1 similar comment
Copy link
Contributor

github-actions bot commented Jun 5, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-redshift contributing guide.

@mikealfare mikealfare marked this pull request as ready for review June 7, 2024 19:04
@mikealfare mikealfare requested a review from a team as a code owner June 7, 2024 19:04
@mikealfare mikealfare marked this pull request as draft June 10, 2024 15:46
@mikealfare mikealfare closed this Nov 9, 2024
@mikealfare mikealfare deleted the remove-dbt-postgres-dependency branch November 9, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Remove dbt-postgres dependency
1 participant