Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the build check workflow #874

Open
mikealfare opened this issue Jul 18, 2024 · 0 comments · May be fixed by #910
Open

Update the build check workflow #874

mikealfare opened this issue Jul 18, 2024 · 0 comments · May be fixed by #910
Labels
tech_debt

Comments

@mikealfare
Copy link
Contributor

mikealfare commented Jul 18, 2024 •
edited
Loading

Current Behavior

We install the wheel, check that the package is installed, then immediately install the sdist, and check that the package is installed again.

Expected Behavior

We should be validating the packages in isolated environments. This arose from the setuptools / packaging issue for dbt-core<1.4, but it's something we should do for current versions as well. See dbt-labs/dbt-core#10465 for the analogous dbt-core issue.
@leahwicz leahwicz linked a pull request Sep 11, 2024 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech_debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Isolating distribution testing leahwicz/dbt-redshift
1 participant
@mikealfare