You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have searched the existing issues, and I could not find an existing issue for this feature
I am requesting a straightforward change to existing dbt-semantic-interfaces functionality, rather than a Big Idea better suited to a discussion
Describe the feature
There has been requests to expose the meta field that's parsed by dbt-core to our interfaces. This would allow users to annotate freely with that field and have that be exposed on our SL APIs. However, this is only supported currently for Metric/SemanticModel, the other are addressed here #195
Spec changes:
SemanticModels
No dbt-core changes needed as it already exists, just need to expose in DSI
semantic_models:
- name: my_model
config:
meta
Metrics
Currently, meta exists on the top-level of Metric. @quigley.malcolm mentioned that it should be moved to be nested under config. Then we can make the necessary changes in DSI.
metrics:
- name: my_metric
meta: ...
to
metrics:
- name: my_metric
config:
meta: ...
Describe alternatives you've considered
No response
Who will this benefit?
Any users interacting with the SL APIs who needs to annotate their metrics or semantic models via their own structure.
Resolves#251
<!---
Include the number of the issue addressed by this PR above if
applicable.
PRs for code changes without an associated issue *will not be merged*.
See CONTRIBUTING.md for more information.
-->
### Description
This PR exposes the `meta` field for Metric and SemanticModel which
enables it to be parsed out in the semantic manifest for use in the SL
APIs
<!---
Describe the Pull Request here. Add any references and info to help
reviewers
understand your changes. Include any tradeoffs you considered.
-->
### Checklist
- [x] I have read [the contributing
guide](https://github.com/dbt-labs/dbt-semantic-interfaces/blob/main/CONTRIBUTING.md)
and understand what's expected of me
- [x] I have signed the
[CLA](https://docs.getdbt.com/docs/contributor-license-agreements)
- [x] This PR includes tests, or tests are not required/relevant for
this PR
- [x] I have run `changie new` to [create a changelog
entry](https://github.com/dbt-labs/dbt-semantic-interfaces/blob/main/CONTRIBUTING.md#adding-a-changelog-entry)
Is this your first time submitting a feature request?
Describe the feature
There has been requests to expose the
meta
field that's parsed by dbt-core to our interfaces. This would allow users to annotate freely with that field and have that be exposed on our SL APIs. However, this is only supported currently for Metric/SemanticModel, the other are addressed here #195Spec changes:
SemanticModels
No dbt-core changes needed as it already exists, just need to expose in DSI
Metrics
Currently,
meta
exists on the top-level of Metric. @quigley.malcolm mentioned that it should be moved to be nested underconfig
. Then we can make the necessary changes in DSI.to
Describe alternatives you've considered
No response
Who will this benefit?
Any users interacting with the SL APIs who needs to annotate their metrics or semantic models via their own structure.
Are you interested in contributing this feature?
No response
Anything else?
No response
From SyncLinear.com | SL-1563
The text was updated successfully, but these errors were encountered: