[Bug] quoting config not working with 1.8
#1074
Comments
colin-rogers-dbt
added
the
High Severity
|
I am experiencing something similar when quoting columns on sources. It appears to work on |
Do you have a cheeky repro? Unit tests are brand new in 1.8 so it's not really an apples to apples with this issue per se - which is a regression of the quoting config in 1.7 > 1.8. In any case, a quick sense check on: Core:
- installed: 1.8.3
- latest: 1.8.3 - Up to date!
Plugins:
- snowflake: 1.8.3 - Up to date!-- create table to test - reserved keyword as col name
create or replace table development_jyeo.dbt_jyeo.raw as (select 1 as "create");# models/sources.yml
version: 2
sources:
- name: dbt_jyeo
tables:
- name: raw
columns:
- name: create
data_tests:
- not_null$ dbt --debug test
22:14:41 On test.my_dbt_project.source_not_null_dbt_jyeo_raw_create.f79610167c: /* {"app": "dbt", "dbt_version": "1.8.3", "profile_name": "all", "target_name": "sf", "node_id": "test.my_dbt_project.source_not_null_dbt_jyeo_raw_create.f79610167c"} */
select
count(*) as failures,
count(*) != 0 as should_warn,
count(*) != 0 as should_error
from (
select create
from development_jyeo.dbt_jyeo.raw
where create is null
) dbt_internal_test
22:14:41 Opening a new connection, currently in state closed
22:14:43 Snowflake adapter: Snowflake query id: 01b56876-0905-0194-000d-378339bd9326
22:14:43 Snowflake adapter: Snowflake error: 001003 (42000): SQL compilation error:
syntax error line 12 at position 7 unexpected 'create'.
syntax error line 14 at position 6 unexpected 'create'.
22:14:43 On test.my_dbt_project.source_not_null_dbt_jyeo_raw_create.f79610167c: Close
22:14:44 Database Error in test source_not_null_dbt_jyeo_raw_create (models/sources.yml)
001003 (42000): SQL compilation error:
syntax error line 12 at position 7 unexpected 'create'.
syntax error line 14 at position 6 unexpected 'create'.
compiled Code at target/run/my_dbt_project/models/sources.yml/source_not_null_dbt_jyeo_raw_create.sql
22:14:44 1 of 1 ERROR source_not_null_dbt_jyeo_raw_create ............................... [ERROR in 2.27s]Error as expected. Add version: 2
sources:
- name: dbt_jyeo
tables:
- name: raw
columns:
- name: create
quote: true
data_tests:
- not_null$ dbt --debug test
22:15:46 On test.my_dbt_project.source_not_null_dbt_jyeo_raw__create_.56364b7a58: /* {"app": "dbt", "dbt_version": "1.8.3", "profile_name": "all", "target_name": "sf", "node_id": "test.my_dbt_project.source_not_null_dbt_jyeo_raw__create_.56364b7a58"} */
select
count(*) as failures,
count(*) != 0 as should_warn,
count(*) != 0 as should_error
from (
select "create"
from development_jyeo.dbt_jyeo.raw
where "create" is null
) dbt_internal_test
22:15:46 Opening a new connection, currently in state closed
22:15:47 SQL status: SUCCESS 1 in 2.0 seconds
22:15:47 On test.my_dbt_project.source_not_null_dbt_jyeo_raw__create_.56364b7a58: Close
22:15:48 1 of 1 PASS source_not_null_dbt_jyeo_raw__create_ .............................. [PASS in 2.26s]Works as expected. This is not a unit test though - not yet familiar with how to set that up. |
|
Interesting when I do this in my project |
Is this a new bug in dbt-snowflake?
Current Behavior
The
quotingconfig doesn't quote the database anymore in 1.8 unlike it did pre-1.8.Expected Behavior
The
quotingconfigs should quote the database like it did pre-1.8.Steps To Reproduce
quoting.database = true:$ dbt --debug run 01:07:44 Sending event: {'category': 'dbt', 'action': 'invocation', 'label': 'start', 'context': [<snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x1046b1510>, <snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x1046efa90>, <snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x1046f7fd0>]} 01:07:44 Running with dbt=1.8.1 01:07:44 running dbt with arguments {'printer_width': '80', 'indirect_selection': 'eager', 'write_json': 'True', 'log_cache_events': 'False', 'partial_parse': 'True', 'cache_selected_only': 'False', 'warn_error': 'None', 'fail_fast': 'False', 'profiles_dir': '/Users/jeremy/.dbt', 'log_path': '/Users/jeremy/git/dbt-basic/logs', 'debug': 'True', 'version_check': 'True', 'use_colors': 'True', 'use_experimental_parser': 'False', 'no_print': 'None', 'quiet': 'False', 'warn_error_options': 'WarnErrorOptions(include=[], exclude=[])', 'introspect': 'True', 'log_format': 'default', 'invocation_command': 'dbt --debug run', 'target_path': 'None', 'static_parser': 'True', 'send_anonymous_usage_stats': 'True'} 01:07:45 Sending event: {'category': 'dbt', 'action': 'project_id', 'label': '7e16f034-b8c9-429a-85e9-e728b206eccf', 'context': [<snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x13518a5d0>]} 01:07:45 Sending event: {'category': 'dbt', 'action': 'adapter_info', 'label': '7e16f034-b8c9-429a-85e9-e728b206eccf', 'context': [<snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x104142590>]} 01:07:45 Registered adapter: snowflake=1.8.2 01:07:45 checksum: ebc509fb14e151ea268e89b60fd5abf912ed99129f87516462718fa2f14f4838, vars: {}, profile: , target: , version: 1.8.1 01:07:45 Unable to do partial parsing because of a version mismatch 01:07:45 Sending event: {'category': 'dbt', 'action': 'partial_parser', 'label': '7e16f034-b8c9-429a-85e9-e728b206eccf', 'context': [<snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x10335f790>]} 01:07:46 Sending event: {'category': 'dbt', 'action': 'load_project', 'label': '7e16f034-b8c9-429a-85e9-e728b206eccf', 'context': [<snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x1353b2750>]} 01:07:46 Sending event: {'category': 'dbt', 'action': 'resource_counts', 'label': '7e16f034-b8c9-429a-85e9-e728b206eccf', 'context': [<snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x136280b90>]} 01:07:46 Found 1 model, 558 macros 01:07:46 Sending event: {'category': 'dbt', 'action': 'runnable_timing', 'label': '7e16f034-b8c9-429a-85e9-e728b206eccf', 'context': [<snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x136451110>]} 01:07:46 01:07:46 Acquiring new snowflake connection 'master' 01:07:46 Acquiring new snowflake connection 'list_1_JYEO' 01:07:46 Using snowflake connection "list_1_JYEO" 01:07:46 On list_1_JYEO: /* {"app": "dbt", "dbt_version": "1.8.1", "profile_name": "all", "target_name": "sf", "connection_name": "list_1_JYEO"} */ show terse schemas in database "1_JYEO" limit 10000 01:07:46 Opening a new connection, currently in state init 01:07:49 SQL status: SUCCESS 3 in 3.0 seconds 01:07:49 On list_1_JYEO: Close 01:07:49 Acquiring new snowflake connection 'list_1_JYEO_dbt_jyeo' 01:07:49 Using snowflake connection "list_1_JYEO_dbt_jyeo" 01:07:49 On list_1_JYEO_dbt_jyeo: /* {"app": "dbt", "dbt_version": "1.8.1", "profile_name": "all", "target_name": "sf", "connection_name": "list_1_JYEO_dbt_jyeo"} */ show objects in 1_JYEO.dbt_jyeo limit 10000 01:07:49 Opening a new connection, currently in state init 01:07:51 Snowflake adapter: Snowflake query id: 01b4d6e3-0804-b779-000d-3783366a862a 01:07:51 Snowflake adapter: Snowflake error: 001003 (42000): SQL compilation error: syntax error line 1 at position 16 unexpected '1'. 01:07:51 Snowflake adapter: Error running SQL: macro list_relations_without_caching 01:07:51 Snowflake adapter: Rolling back transaction. 01:07:51 On list_1_JYEO_dbt_jyeo: Close 01:07:51 Connection 'master' was properly closed. 01:07:51 Connection 'list_1_JYEO' was properly closed. 01:07:51 Connection 'list_1_JYEO_dbt_jyeo' was properly closed. 01:07:51 01:07:51 Finished running in 0 hours 0 minutes and 5.47 seconds (5.47s). 01:07:51 Encountered an error: Database Error 001003 (42000): SQL compilation error: syntax error line 1 at position 16 unexpected '1'. 01:07:51 Resource report: {"command_name": "run", "command_wall_clock_time": 7.0150514, "process_user_time": 3.133745, "process_kernel_time": 1.425414, "process_mem_max_rss": "202407936", "command_success": false, "process_in_blocks": "0", "process_out_blocks": "0"} 01:07:51 Command `dbt run` failed at 13:07:51.939918 after 7.02 seconds 01:07:51 Sending event: {'category': 'dbt', 'action': 'invocation', 'label': 'end', 'context': [<snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x104717f10>, <snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x104717e90>, <snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x100afc310>]} 01:07:51 Flushing usage eventsRelevant log output
No response
Environment
Additional Context
I don't think schema quoting is working either.
1.8:
dbt-snowflake/dbt/include/snowflake/macros/adapters.sql
Line 127 in cc13888
1.7:
dbt-snowflake/dbt/include/snowflake/macros/adapters.sql
Line 127 in f1fc948
The text was updated successfully, but these errors were encountered: