Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Table testing improvements #1186

Closed
wants to merge 20 commits into from

Conversation

mikealfare
Copy link
Contributor

Problem

Dynamic table testing takes a long time to run and is difficult to add to. We need to add Iceberg table format support and updating the tests would make it easier to add to.

Solution

Update the tests separately in this PR and then rebase the existing Snowflake PR on this one.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare added the Skip Changelog Skips GHA to check for changelog file label Sep 20, 2024
@mikealfare mikealfare self-assigned this Sep 20, 2024
@mikealfare mikealfare requested a review from a team as a code owner September 20, 2024 16:35
@cla-bot cla-bot bot added the cla:yes label Sep 20, 2024
@mikealfare
Copy link
Contributor Author

need to git better

@mikealfare mikealfare closed this Sep 20, 2024
@mikealfare mikealfare deleted the dynamic-tables/testing-improvements branch September 20, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant