Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADAP-1115: Move to hatch and pyproject.toml #1250

Merged
merged 67 commits into from
Dec 20, 2024
Merged

ADAP-1115: Move to hatch and pyproject.toml #1250

merged 67 commits into from
Dec 20, 2024

Conversation

mikealfare
Copy link
Contributor

We are moving to a monorepo that uses pyproject.toml and hatch. This requires a series of migrations, including this one. This PR inclues:

  • update from setup.py/dev-requirements.txt to pyproject.toml/hatch.toml
  • move tool config (e.g. mypy and pytest) into pyproject.toml
  • update workflows regarding these moves
  • delete configs that no longer apply (e.g. tox.ini, pytest.ini, etc.)

@mikealfare mikealfare self-assigned this Nov 17, 2024
@cla-bot cla-bot bot added the cla:yes label Nov 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

@mikealfare
Copy link
Contributor Author

Since CI is target branch based, here's the actual integration test run: https://github.com/dbt-labs/dbt-snowflake/actions/runs/11883218656

@mikealfare mikealfare marked this pull request as ready for review November 18, 2024 02:05
@mikealfare mikealfare requested a review from a team as a code owner November 18, 2024 02:05
@mikealfare mikealfare marked this pull request as draft November 19, 2024 23:06
@mikealfare mikealfare changed the title Move to hatch and pyproject.toml ADAP-1115: Move to hatch and pyproject.toml Dec 4, 2024
@mikealfare
Copy link
Contributor Author

Integrations that run against the workflow in this branch:
https://github.com/dbt-labs/dbt-snowflake/actions/runs/12215746378

@mikealfare mikealfare marked this pull request as ready for review December 7, 2024 20:07
mikealfare and others added 25 commits December 10, 2024 22:04
@mikealfare
pin snowflake sdk to troubleshoot ci memory issues
acd933e
@mikealfare
add ddtrace back; it doesn't look like that's causing the memory issue
7c2ae97
@mikealfare
break out incremental tests from other tests because that's where CI …
3d64a46 
…is stopping with memory issues in GHA on Ubuntu
@mikealfare
break out tests into one module at a time to troubleshoot memory issu…
ac29ea2 
…es in GHA on Ubuntu
@mikealfare
add filter for utcnow deprecation, remove filter for resource warning
8f0d68c
@mikealfare
add filter for utcnow deprecation, remove filter for resource warning
78469fe
@mikealfare
add filter for utcnow deprecation, remove filter for resource warning
7f72f56
@mikealfare
add filter for utcnow deprecation, remove other filters
5e76a7e
@mikealfare
remove pytest warning filters
c82b6b6
@mikealfare
remove pytest warning filter for utcnow deprecation
5755940
@mikealfare
add test groups to troubleshoot where the memory issue on ubuntu
9377c5f
@mikealfare
swap args order for pytest, don't mark anything outside of functional…
c524822 
… tests
@mikealfare
group_6 was missing
58d8b66
@mikealfare
remove group_2 and isolate newer tests into group_6
b069393
@mikealfare
remove group_3 and group_4
3439bc4
@mikealfare
add group_4 back in
b85682a
@mikealfare
move more things into group_1
2b66d21
@mikealfare
Merge branch 'main' into move-to-hatch
8b416c3
@mikealfare
group tests by when they were updated for troubleshooting
24c57af
@mikealfare
pull out python model tests for troubleshooting
764dbdd
@mikealfare
mark high memory tests and run as a separate pytest run
37d2dae
@mikealfare
mark high memory tests and run as a separate pytest run
eb06873
@mikealfare
fix build targets
40ec4b5
@mikealfare
remove high_memory marker
c6f90e7
@mikealfare
reduce pr noise
594de08
@mikealfare
Copy link
Contributor Author

Working integration tests: https://github.com/dbt-labs/dbt-snowflake/actions/runs/12422067422

@mikealfare mikealfare merged commit b687ac4 into main Dec 20, 2024
13 of 14 checks passed
@mikealfare mikealfare deleted the move-to-hatch branch December 20, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VersusFacit VersusFacit VersusFacit approved these changes

Assignees

@mikealfare mikealfare

Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikealfare @VersusFacit