Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit external volume from DDL when not provided #1302

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dlouseiro
Copy link

@dlouseiro dlouseiro commented Jan 29, 2025

resolves #

Problem

When a external_volume is omitted in the configuration of an Iceberg table, the create table statement uses external_volume='None'.

Solution

Omit external_volume from relation's DDL when it's not provided.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@dlouseiro dlouseiro requested a review from a team as a code owner January 29, 2025 10:27
@cla-bot cla-bot bot added the cla:yes label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] External volume name set as None when omitted in Iceberg tables
1 participant