Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAP-547] [Feature] Pagination to allow >10k schemas per database #605

Closed
3 tasks done
jaypeedevlin opened this issue May 12, 2023 · 6 comments
Closed
3 tasks done
Labels
enhancement New feature or request Stale

Comments

@jaypeedevlin
Copy link
Contributor

jaypeedevlin commented May 12, 2023

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt-snowflake functionality, rather than a Big Idea better suited to a discussion

Describe the feature

#571 used pagination to support retrieving >10k objects in a schema. The same pattern can be used to enable >10k schemas in a database.

I propose to use the same technique for the latter as the former (which I've confirmed Snowflake supports).

Describe alternatives you've considered

Overriding the macro in our project.

Who will this benefit?

Anyone using dbt at scale — specifically we run into this from time to time with our databases that create an environment per PR for dev.

Are you interested in contributing this feature?

Yes!

Anything else?

No response

@jaypeedevlin jaypeedevlin added enhancement New feature or request triage labels May 12, 2023
@github-actions github-actions bot changed the title [Feature] <title> [ADAP-547] [Feature] <title> May 12, 2023
@jaypeedevlin jaypeedevlin changed the title [ADAP-547] [Feature] <title> [ADAP-547] [Feature] Pagination to allow >10k schemas per database May 12, 2023
@dbeatty10
Copy link
Contributor

Thanks for opening this @jaypeedevlin !

✅ Green light for you to use the same technique as #572 but applied to >10k schemas.

In a ideal world, you will be able to refactor snowflake__get_paginated_relations_array slightly so that its logic can be reused rather than copy-pasted.

The crux would be generalizing the paginated_sql portion.

Ultimately, that will be up to you and the code reviewer to work out.

@dbeatty10 dbeatty10 removed the triage label May 12, 2023
Copy link
Contributor

github-actions bot commented Nov 9, 2023

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 9, 2023
@jaypeedevlin
Copy link
Contributor Author

Bump

@github-actions github-actions bot removed the Stale label Nov 13, 2023
@ttishihara
Copy link

Hello, are there any updates for this or any new related issues?

Copy link
Contributor

github-actions bot commented Sep 1, 2024

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Sep 1, 2024
Copy link
Contributor

github-actions bot commented Sep 9, 2024

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Stale
Projects
None yet
Development

No branches or pull requests

3 participants