Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAP-1031] [Bug] send_anonymous_usage_stats ignored for python models #830

Closed
2 tasks done
Dikootje opened this issue Nov 13, 2023 · 2 comments · Fixed by #933 or #948
Closed
2 tasks done

[ADAP-1031] [Bug] send_anonymous_usage_stats ignored for python models #830

Dikootje opened this issue Nov 13, 2023 · 2 comments · Fixed by #933 or #948
Assignees
Labels
backport 1.7.latest Tag for PR to be backported to the 1.7.latest branch bug Something isn't working High Severity bug with significant impact that should be resolved in a reasonable timeframe support
Milestone

Comments

@Dikootje
Copy link

Is this a new bug in dbt-snowflake?

  • I believe this is a new bug in dbt-snowflake
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

When running python models against Snowflake a telemetry header is added to the procedure.

import sys
sys._xoptions['snowflake_partner_attribution'].append("dbtLabs_dbtPython")

Even with the profiles.yml configured in a what that should prevent this:

config:
  send_anonymous_usage_stats: false

Expected Behavior

When send_anonymous_usage_status is set to false I expect the telemetry snippet not to be inserted in the python code that is send to Snowflake.

sys._xoptions['snowflake_partner_attribution'].append("{snowpark_telemetry_string}")"""

Steps To Reproduce

  1. Using dbt-core v1.7.0 and dbt-snowflake v1.7.0
  2. Create any python model
  3. Execute using Snowflake
  4. Look up the query in the snowflake query history

Relevant log output

No response

Environment

- OS: any
- Python: 3.11
- dbt-core: 1.7.0
- dbt-snowflake: 1.7.0

Additional Context

When auditing the Snowflake query log, we've discovered that dbt usage is being tracked even when this is set specifically to false in the dbt profiles.yml.

@Dikootje Dikootje added bug Something isn't working triage labels Nov 13, 2023
@github-actions github-actions bot changed the title [Bug] send_anonymous_usage_stats ignored for python models [ADAP-1031] [Bug] send_anonymous_usage_stats ignored for python models Nov 13, 2023
@dbeatty10
Copy link
Contributor

Thanks you for reporting this @Dikootje !

Acceptance criteria

  • send_anonymous_usage_stats config is respected for dbt-snowflake
  • When true, dbt usage will show in the Snowflake query log
  • When false, dbt usage will not show in the Snowflake query log (because it is not being tracked)

@dbeatty10 dbeatty10 removed the triage label Nov 13, 2023
@martynydbt martynydbt added the High Severity bug with significant impact that should be resolved in a reasonable timeframe label Feb 3, 2024
@martynydbt martynydbt added the backport 1.7.latest Tag for PR to be backported to the 1.7.latest branch label Feb 23, 2024
@martynydbt martynydbt added this to the 1.8.0 milestone Feb 23, 2024
@mikealfare
Copy link
Contributor

Re-opening for backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.7.latest Tag for PR to be backported to the 1.7.latest branch bug Something isn't working High Severity bug with significant impact that should be resolved in a reasonable timeframe support
Projects
None yet
4 participants