Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adap-435 Use explicit begin transaction #886

Conversation

shreyadatar
Copy link

resolves #556
docs dbt-labs/docs.getdbt.com/#

Problem

See #556, Mixing Snowflake begin/end scripting blocks with transactions throws a syntax error.

Solution

By using the more explicit begin transaction instead of begin, the above confusion and syntax error is avoided, therefore allowing both begin/end blocks as well as transactions being used together.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@shreyadatar shreyadatar requested a review from a team as a code owner January 13, 2024 00:51
Copy link

cla-bot bot commented Jan 13, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: =.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@shreyadatar
Copy link
Author

Going to start over to make cla-bot like this.

@shreyadatar shreyadatar deleted the bug/adap-435-begin-end-scripting branch January 13, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADAP-435] [Bug] Cannot use begin/end scripting statement with snowflake_dml_explicit_transaction
1 participant