Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PrivateLink Egress #3988

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Fix PrivateLink Egress #3988

merged 1 commit into from
Aug 30, 2023

Conversation

runleonarun
Copy link
Collaborator

What are you changing in this pull request and why?

privatelink works with only consistent cloud providers. Since MT is on AWS, privatelink is only available for customers also on AWS.

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Adding new pages (delete if not applicable):

  • Add page to website/sidebars.js
  • Provide a unique filename for the new page

Removing or renaming existing pages (delete if not applicable):

  • Remove page from website/sidebars.js
  • Add an entry website/static/_redirects
  • Ran link testing to update the links that point to the deleted page

@runleonarun runleonarun requested a review from a team as a code owner August 30, 2023 01:00
@netlify
Copy link

netlify bot commented Aug 30, 2023 •
edited
Loading

✅ Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit 9f212cb
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/64ee94cb7743a0000784c4f8
😎 Deploy Preview https://deploy-preview-3988--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. Docs team Authored by the Docs team @dbt Labs labels Aug 30, 2023
mirnawong1
mirnawong1 approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 @runleonarun

@mirnawong1 mirnawong1 merged commit 73328b1 into current Aug 30, 2023
12 checks passed
@mirnawong1 mirnawong1 deleted the runleonarun-patch-10 branch August 30, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirnawong1 mirnawong1 mirnawong1 approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: x-small This change will take under 3 hours to fix.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@runleonarun @mirnawong1