Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-cell doc updates #3996

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Multi-cell doc updates #3996

merged 3 commits into from
Aug 31, 2023

Conversation

matthewshaver
Copy link
Contributor

What are you changing in this pull request and why?

Taking the initial steps to update our documents for multi-cell architecture

Updating URL tables, SSO login instructions, and webhook page examples

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

@matthewshaver matthewshaver requested a review from a team as a code owner August 30, 2023 21:15
@netlify
Copy link

netlify bot commented Aug 30, 2023

Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit 5bd42c4
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/64f0eebd0da04a00088d3bc4
😎 Deploy Preview https://deploy-preview-3996--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address Docs team Authored by the Docs team @dbt Labs labels Aug 30, 2023
@@ -11,10 +11,17 @@ dbt Cloud is [hosted](/docs/cloud/about-cloud/architecture) in multiple regions

| Region | Location | Access URL | IP addresses | Developer plan | Team plan | Enterprise plan |
|--------|----------|------------|--------------|----------------|-----------|-----------------|
| North America [^1] | AWS us-east-1 (N. Virginia) | cloud.getdbt.com | 52.45.144.63 <br /> 54.81.134.249 <br />52.22.161.231 | ✅ | ✅ | ✅ |
| North America multi-tenant [^1] | AWS us-east-1 (N. Virginia) | cloud.getdbt.com | 52.45.144.63 <br /> 54.81.134.249 <br />52.22.161.231 | ✅ | ✅ | ✅ |
| North America Cell 1 [^1] | AWS use-east-1 (N.Virginia) | {account prefix}.us1.dbt.com | [Located in Account Settings](#locating-your-dbt-cloud-ip-addresses) | ❌ | ❌ | ❌ |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is cool! one thing i'd suggest is possibly having a separate section or page dedicated to explaining access URLs in more detail since this table is getting more sophisticated.snowflake has a semi-related page that explains URLs in more detail.

also maybe a bit more context on what account prefix means since this is kind of new?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 -- @mirnawong1 I think it's a good idea to include a dedicated page explaining access URLs

Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great and what a huge effort that will help our users! some suggestions @matthewshaver on my end and approved!

```

#### Path parameters
| Name | Description |
|------------|--------------------------------------|
| `your access URL` | The login URL for your dbt Cloud account. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

piggybacking on what I said above. we should have a dedicated page that explains these concepts:

  • what is a login URL
  • what is an access URL

these might be different, and we should take care to say what they are, how they're constructed, how to find them, and when to use each one

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthewshaver I think this is an improvement as-is, but maybe I can help write the "connect" page and then come back and update these docs with the language we decide on? idk. let me know how I can help

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmcarthur Is this a requiremnent for the initial client(s) we're enabling? I have it on my to-do list but was going to work on it the second week in Sept. I don't mind writing it up!

@matthewshaver matthewshaver merged commit dda9c52 into current Aug 31, 2023
10 checks passed
@matthewshaver matthewshaver deleted the multi-cell branch August 31, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants