Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Allow cumulative metrics without having to pre-define them #1528

Open
3 tasks done
siljamardla opened this issue Nov 13, 2024 · 0 comments
Open
3 tasks done
Labels
enhancement New feature or request triage Tasks that need to be triaged

Comments

@siljamardla
Copy link

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing metricflow functionality, rather than a Big Idea better suited to a discussion

Describe the feature

Allow users to query cumulative values of metrics without developers having to pre-define the metrics.
If necessary, there can be additional configurations that specify which cumulative calculations to enable or disable.

Ideally, we would define a metric (some_metric) and we would immediately be able to query a cumulative version of that metric, something like this:

mf query --metircs some_metric,cumulative_7_day__some_metric --group-by metric_time

That is, the cumulation parameters would be query-time, not definition time.

Describe alternatives you've considered

Currently we have to pre-configure all the cumulative metrics we want to allow, which is limiting and code-intensive. For example:

  - name: some_metric_in_7_days
    label: some_metric_in_7_days
    description: ...
    type: cumulative
    type_params:
      measure: some_measure
      window: 7 days

to enable the 7-day cumulative and another one for every other window we want to allow.

Who will this benefit?

Everyone using metrics

Are you interested in contributing this feature?

Happy to provide context, sample use cases, brainstorm etc

Anything else?

No response

@siljamardla siljamardla added enhancement New feature or request triage Tasks that need to be triaged labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage Tasks that need to be triaged
Projects
None yet
Development

No branches or pull requests

1 participant