Align dataflow plans #1511
Merged
Align dataflow plans #1511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courtneyholcomb
force-pushed
the
court/align-dfp
branch
from
a3c65db to
d7bd513
Compare
courtneyholcomb
force-pushed
the
court/align-dfp
branch
2 times, most recently
from
c2eec4f to
fbc9c9f
Compare
courtneyholcomb
force-pushed
the
court/align-dfp
branch
from
08c3e00 to
35fef1a
Compare
courtneyholcomb
commented
Nov 8, 2024
| @@ -328,34 +328,23 @@ def _build_aggregated_conversion_node( | |||
| ) | |||
|
|
|||
| # Build the unaggregated base measure node for computing conversions | |||
| unaggregated_base_measure_node = base_measure_recipe.source_node | |||
| if base_measure_recipe.join_targets: | |||
There was a problem hiding this comment.
There are a few snapshot changes here, and this is the source of those changes. When we call join_targets, it creates a FilterElementsNode under the hood, even if we don't use it. On this line, we call join_targets without using the node that gets generated. The new code only calls join_targets once and uses the generated node, so there the source node IDs are incremented fewer times.
This is true for the other parts of the code referencing join_targets in this PR, too.
plypaul
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dedupe logic in the
DataflowPlanBuilder. Diverging paths in the dataflow plan have frequently been a source of bugs. To reduce similar future bugs, this PR unifies some of the logic across all paths. There are several steps we always take after source node generation and before aggregation. This PR moves all that logic into a helper function to ensure we always use the same logic.