Expose measures for metrics on MFEngine #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
tlento
reviewed
Aug 25, 2023
There was a problem hiding this comment.
Apart from the typechecker override this all seems reasonable. I think it'll be more expedient to keep the change at the level of the engine and use the existing semantic_model_lookup methods to populate the additional fields you need.
Would you mind also updating the PR description with a little more context on why this change is being made? I'm assuming it's to support metadata lookups on the cloud side, but it's not clear to me how we're expecting this method to be used from the PR itself.
Thanks!
tlento
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #SL-814
Description
Expose measures for metrics on MFEngine, ensuring that
agg_time_dimensionis populated even when it is inherited from the semantic model default.We need to know the agg_time_dimension for a given measure so that the API can expose a list of all measures and the name of their
agg_time_dimensionfor a given metric. This allows users to understand whatmetric_timeactually represents for a given metric.