Updates to snapshot generation script #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
tlento
approved these changes
Aug 29, 2023
| @@ -74,7 +74,8 @@ def __configure_test_env_from_url(url: str, password: str, schema: str) -> sqlal | |||
|
|
|||
| def __configure_bigquery_env_from_credential_string(password: str, schema: str) -> None: | |||
| credential_string = password.replace("'", "") | |||
| credentials = json.loads(credential_string) | |||
| # `strict=False` required to work with BQ password characters. | |||
| credentials = json.loads(credential_string, strict=False) | |||
There was a problem hiding this comment.
Interesting, the CI credential string doesn't need this. I can't remember what kind of escaping I did to get it working, though. Must be something to do with the nested JSON. Anyway everything seems fine so 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a couple of small issues with the snapshot generation script: