Remove unnecessary JoinOverTimeRange
step from dataflow plan
#743
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, for all cumulative metrics, we add a
JoinOverTimeRange
step to the dataflow plan. However, some cumulative metrics are able to be queried withoutmetric_time
, in which case we should notJoinOverTimeRange
. When we visit that node unnecessarily, there are two repercussions:JoinOverTimeRangeNode
assumesnum_aggregations=1
. This results innum_aggregations
being off by 1 for the overall query.This PR removes that unneeded step from the dataflow plan.