Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing download button on view page #31

Open
sanderbaas opened this issue Sep 19, 2023 · 4 comments
Open

Missing download button on view page #31

sanderbaas opened this issue Sep 19, 2023 · 4 comments

Comments

@sanderbaas
Copy link

I have implemented the field as follows:

Filepond::make(__('Files'), 'files')
                ->prunable()
                ->disableCredits()
                ->disk('event-edition-resources')
                ->storeOriginalName('name')
                ->multiple(),

Uploading works perfectly, but I do not see a download button on the view page. If I remember correctly there was a download button in the Nova3 version of this field.

afbeelding

The property downloadsAreEnabled that is inherited from the File field is true on runtime.

@milewski
Copy link
Member

Uhm I think previously this wasn't there too, there was this issue where I mentioned a plugin that could achieve that: #14 I will try to implement now

@milewski
Copy link
Member

Hi, I implemented the change here: #32

However, there are a few issues:

  • There doesn't seem to be a way to register the plugin locally, it is always registered globally which causes all other fields that have disableDownload option set to be ignored
  • There is no way to have the download link when the preview is disabled... it seems there is an undocumented option that can be enabled which would allow to generate a URL from the backend but it inst working: allowDownloadByUrl does not work nielsboogaard/filepond-plugin-get-file#12

Feels like the only way around would be by forking that plugin and making a few changes:

  • Add a new option to enable/disable the plugin
  • Fix the issue with the allowDownloadByUrl not working

@reytarovskiy
Copy link

any updates on this?

@RealityGamin
Copy link

This is an amazing system but we really need to have a downloadable option :(

please @milewski

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants