Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module compiled with Swift 5.1.2 cannot be imported by the Swift 5.2 compiler #23

Open
react-native-engineer opened this issue Apr 7, 2020 · 10 comments · May be fixed by #24
Open

Module compiled with Swift 5.1.2 cannot be imported by the Swift 5.2 compiler #23

react-native-engineer opened this issue Apr 7, 2020 · 10 comments · May be fixed by #24

Comments

@react-native-engineer
Copy link

No description provided.

@maxhungry maxhungry linked a pull request Apr 10, 2020 that will close this issue
@ghost
Copy link

ghost commented May 28, 2020

Is there any fix available for this issue ??

@thedarkcder
Copy link

Anybody get the PR to work?

@Meegul
Copy link

Meegul commented Jul 14, 2020

I was able to get it to work. I took the changes from PR #24 in my locally installed version of react-native-zendesk, but had to then re-run pod install. Then, there was a build issue where I had to comment out a line that would hide the support -- this should be easy to find.

@thedarkcder
Copy link

Me to - needed to update Xcode to latest.

But I'm using another updated fork

@Meegul
Copy link

Meegul commented Jul 14, 2020

What's the fork? Not too keen on managing a fork myself, and I will need to use one until this library gets updated.

@thedarkcder
Copy link

There you go

https://github.com/thanx/react-native-zendesk

No offence jacky

@maxhungry
Copy link

maxhungry commented Jul 14, 2020

Just a note, before #24 is merged I had to do this for a workaround with the Swift 5.2 changes: maxhungry@572e65f

@pentolbakso
Copy link

Do we need to use swift 5.2 in order to use the library ( zendesk supportSdk ) ? Dang, then I would need to upgrade to Catalina

@thedarkcder
Copy link

I couldn't get many things to work properly with out upgrading.

I had to upgrade to Catalina, now I need to figure out how to run my 32bit apps.

@ravindranpandu
Copy link

I had the same issue after updating to catalina OS / xCode 11.5, swift compiler 5.2 couldn't compile swift 5.1 modules in the zendesk sdk, finally i followed @maxhungry PR #24 and it worked finally, important task is to build your local node_modules/react-native-zendesk folder with yarn build or npm build only then you can import the js files from lib folder.

FInally i automated the react-native-zendesk build it with yarn's post-build hook command which is less pain for frequent builds.

you need to do yarn install or npm install, cd ios && pod install again to make this work.

Hope this will help someone who is facing this issue here, cheers 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants