feat: add usage and notification access checks in ExperimentalRpcScreen

Author: dead8309

app/src/main/java/com/my/kizzy/Kizzy.kt

@@ -19,6 +19,7 @@ import androidx.activity.viewModels
 import androidx.compose.animation.ExperimentalAnimationApi
 import androidx.compose.material3.Scaffold
 import androidx.compose.runtime.Composable
+import androidx.compose.runtime.MutableState
 import androidx.compose.runtime.collectAsState
 import androidx.compose.runtime.getValue
 import androidx.compose.runtime.mutableStateOf
@@ -64,7 +65,10 @@ import xyz.dead8309.feature_experimental_rpc.apps.ExperimentalRpcAppsScreen
 @SuppressLint("UnusedMaterial3ScaffoldPaddingParameter")
 @OptIn(ExperimentalAnimationApi::class)
 @Composable
-internal fun ComponentActivity.Kizzy() {
+internal fun ComponentActivity.Kizzy(
+    usageAccessStatus: MutableState<Boolean>,
+    notificationListenerAccess: MutableState<Boolean>,
+) {
     Scaffold()
     {
         val navController = rememberAnimatedNavController()
@@ -74,8 +78,8 @@ internal fun ComponentActivity.Kizzy() {
         ) {
             animatedComposable(Routes.SETUP) {
                 StartUp(
-                    usageAccessStatus = MainActivity.usageAccessStatus,
-                    mediaControlStatus = MainActivity.notificationListenerAccess,
+                    usageAccessStatus = usageAccessStatus,
+                    mediaControlStatus = notificationListenerAccess,
                     navigateToLanguages = {
                         navController.navigate(Routes.LANGUAGES) {
                             launchSingleTop = true
@@ -113,8 +117,8 @@ internal fun ComponentActivity.Kizzy() {
                     showBadge = showBadge,
                     features = homeFeaturesProvider(
                         navigateTo = { navController.navigate(it) },
-                        hasUsageAccess = MainActivity.usageAccessStatus,
-                        hasNotificationAccess = MainActivity.notificationListenerAccess,
+                        hasUsageAccess = usageAccessStatus,
+                        hasNotificationAccess = notificationListenerAccess,
                         userVerified = user?.verified == true
                     ),
                     user = user,
@@ -143,7 +147,7 @@ internal fun ComponentActivity.Kizzy() {
                 val viewModel by viewModels<AppsScreenViewModel>()
                 AppsRPC(
                     onBackPressed = { navController.popBackStack() },
-                    hasUsageAccess = MainActivity.usageAccessStatus.value,
+                    hasUsageAccess = usageAccessStatus.value,
                     state = viewModel.state.collectAsState().value,
                     updateAppEnabled = viewModel::updateAppEnabled,
                 )
@@ -161,6 +165,7 @@ internal fun ComponentActivity.Kizzy() {
                 MediaRPC(
                     onBackPressed = { navController.popBackStack() },
                     state = viewModel.state.collectAsState().value,
+                    hasNotificationAccess = notificationListenerAccess.value,
                     updateMediaAppEnabled = viewModel::updateMediaAppEnabled
                 )
             }
@@ -247,6 +252,8 @@ internal fun ComponentActivity.Kizzy() {
                     state = experimentalRpcViewModel.value.uiState.collectAsState().value,
                     onEvent = experimentalRpcViewModel.value::onEvent,
                     onBackPressed = { navController.popBackStack() },
+                    hasUsageAccess = usageAccessStatus.value,
+                    hasNotificationAccess = notificationListenerAccess.value,
                     navigateToAppSelection = {
                         navController.navigate(Routes.EXPERIMENTAL_RPC_APPS)
                     },

app/src/main/java/com/my/kizzy/MainActivity.kt

@@ -5,16 +5,17 @@ import android.content.Context
 import android.content.pm.PackageManager
 import android.os.Build
 import android.os.Bundle
+import android.provider.Settings
 import androidx.activity.compose.setContent
 import androidx.appcompat.app.AppCompatActivity
 import androidx.appcompat.app.AppCompatDelegate
 import androidx.compose.material3.windowsizeclass.ExperimentalMaterial3WindowSizeClassApi
 import androidx.compose.material3.windowsizeclass.calculateWindowSizeClass
-import androidx.compose.runtime.*
+import androidx.compose.runtime.MutableState
+import androidx.compose.runtime.mutableStateOf
 import androidx.core.os.LocaleListCompat
 import androidx.core.view.ViewCompat
 import androidx.core.view.WindowCompat
-import com.my.kizzy.feature_media_rpc.hasNotificationAccess
 import com.my.kizzy.preference.getLanguageConfig
 import com.my.kizzy.ui.theme.KizzyTheme
 import com.my.kizzy.ui.theme.LocalDarkTheme
@@ -25,6 +26,8 @@ import kotlinx.coroutines.runBlocking
 
 @AndroidEntryPoint
 class MainActivity : AppCompatActivity() {
+    private lateinit var usageAccessStatus: MutableState<Boolean>
+    private lateinit var notificationListenerAccess: MutableState<Boolean>
 
     @OptIn(ExperimentalMaterial3WindowSizeClassApi::class)
     override fun onCreate(savedInstanceState: Bundle?) {
@@ -50,7 +53,10 @@ class MainActivity : AppCompatActivity() {
                     isHighContrastModeEnabled = LocalDarkTheme.current.isHighContrastModeEnabled,
                     isDynamicColorEnabled = LocalDynamicColorSwitch.current,
                 ) {
-                    Kizzy()
+                    Kizzy(
+                        usageAccessStatus = usageAccessStatus,
+                        notificationListenerAccess = notificationListenerAccess,
+                    )
                 }
             }
         }
@@ -62,31 +68,36 @@ class MainActivity : AppCompatActivity() {
         usageAccessStatus.value = hasUsageAccess()
     }
 
+    @Suppress("DEPRECATION")
+    private fun Context.hasUsageAccess(): Boolean {
+        return try {
+            val packageManager: PackageManager = this.packageManager
+            val applicationInfo = packageManager.getApplicationInfo(this.packageName, 0)
+            val appOpsManager = this.getSystemService(APP_OPS_SERVICE) as AppOpsManager
+            val mode = appOpsManager.checkOpNoThrow(
+                AppOpsManager.OPSTR_GET_USAGE_STATS,
+                applicationInfo.uid,
+                applicationInfo.packageName
+            )
+            mode == AppOpsManager.MODE_ALLOWED
+        } catch (_: PackageManager.NameNotFoundException) {
+            false
+        }
+    }
+
+    private fun Context.hasNotificationAccess(): Boolean {
+        val enabledNotificationListeners = Settings.Secure.getString(
+            this.contentResolver, "enabled_notification_listeners"
+        )
+        return enabledNotificationListeners != null && enabledNotificationListeners.contains(this.packageName)
+    }
 
     companion object {
-        lateinit var usageAccessStatus: MutableState<Boolean>
-        lateinit var notificationListenerAccess: MutableState<Boolean>
         fun setLanguage(locale: String) {
             val localeListCompat =
                 if (locale.isEmpty()) LocaleListCompat.getEmptyLocaleList()
                 else LocaleListCompat.forLanguageTags(locale)
             AppCompatDelegate.setApplicationLocales(localeListCompat)
         }
-
-        @Suppress("DEPRECATION")
-        fun Context.hasUsageAccess(): Boolean {
-            return try {
-                val packageManager: PackageManager = this.packageManager
-                val applicationInfo = packageManager.getApplicationInfo(this.packageName, 0)
-                val appOpsManager = this.getSystemService(Context.APP_OPS_SERVICE) as AppOpsManager
-                val mode = appOpsManager.checkOpNoThrow(
-                    AppOpsManager.OPSTR_GET_USAGE_STATS,
-                    applicationInfo.uid,
-                    applicationInfo.packageName)
-                mode == AppOpsManager.MODE_ALLOWED
-            } catch (e: PackageManager.NameNotFoundException) {
-                false
-            }
-        }
     }
 }

feature_experimental_rpc/src/main/java/xyz/dead8309/feature_experimental_rpc/ExperimentalRpcScreen.kt

@@ -13,6 +13,8 @@
 package xyz.dead8309.feature_experimental_rpc
 
 import android.content.Intent
+import android.provider.Settings
+import androidx.compose.animation.AnimatedVisibility
 import androidx.compose.foundation.layout.Arrangement
 import androidx.compose.foundation.layout.Column
 import androidx.compose.foundation.layout.fillMaxSize
@@ -21,9 +23,11 @@ import androidx.compose.foundation.layout.padding
 import androidx.compose.foundation.layout.size
 import androidx.compose.foundation.lazy.LazyColumn
 import androidx.compose.material.icons.Icons
+import androidx.compose.material.icons.filled.AppsOutage
 import androidx.compose.material.icons.filled.PauseCircle
 import androidx.compose.material.icons.filled.PlayCircle
 import androidx.compose.material.icons.filled.Timer
+import androidx.compose.material.icons.filled.Warning
 import androidx.compose.material.icons.outlined.AppSettingsAlt
 import androidx.compose.material.icons.outlined.Apps
 import androidx.compose.material.icons.outlined.Image
@@ -62,6 +66,7 @@ import com.my.kizzy.ui.components.SettingItem
 import com.my.kizzy.ui.components.Subtitle
 import com.my.kizzy.ui.components.SwitchBar
 import com.my.kizzy.ui.components.preference.PreferenceSwitch
+import com.my.kizzy.ui.components.preference.PreferencesHint
 
 private val completions = listOf(
     TemplateKeys.MEDIA_TITLE to R.string.completion_media_title,
@@ -75,6 +80,8 @@ private val completions = listOf(
 fun ExperimentalRpcScreen(
     onBackPressed: () -> Unit,
     state: UiState,
+    hasUsageAccess: Boolean,
+    hasNotificationAccess: Boolean,
     navigateToAppSelection: () -> Unit,
     onEvent: (UiEvent) -> Unit,
 ) {
@@ -104,9 +111,38 @@ fun ExperimentalRpcScreen(
     ) { paddingValues ->
 
         Column(modifier = Modifier.padding(paddingValues)) {
+            AnimatedVisibility(
+                visible = !hasUsageAccess
+            ) {
+                PreferencesHint(
+                    title = stringResource(id = R.string.usage_access),
+                    description = stringResource(id = R.string.usage_access_desc),
+                    icon = Icons.Default.AppsOutage,
+                ) {
+                    when (hasUsageAccess) {
+                        false -> context.startActivity(Intent(Settings.ACTION_USAGE_ACCESS_SETTINGS))
+                        else -> Unit
+                    }
+                }
+            }
+            AnimatedVisibility(
+                visible = !hasNotificationAccess
+            ) {
+                PreferencesHint(
+                    title = stringResource(id = R.string.permission_required),
+                    description = stringResource(id = R.string.request_for_notification_access),
+                    icon = Icons.Default.Warning,
+                ) {
+                    if (!hasNotificationAccess) {
+                        context.startActivity(Intent(Settings.ACTION_NOTIFICATION_LISTENER_SETTINGS))
+                    }
+                }
+            }
+
             SwitchBar(
                 title = stringResource(id = R.string.enable_experimental_rpc),
                 isChecked = experimentalRpcRunning,
+                enabled = hasUsageAccess && hasNotificationAccess,
             ) {
                 experimentalRpcRunning = !experimentalRpcRunning
                 when (experimentalRpcRunning) {

feature_media_rpc/src/main/java/com/my/kizzy/feature_media_rpc/HasNotificationAccess.kt

@@ -79,6 +79,7 @@ import com.my.kizzy.ui.components.preference.PreferencesHint
 fun MediaRPC(
     onBackPressed: () -> Unit,
     state: MediaAppsState,
+    hasNotificationAccess: Boolean,
     updateMediaAppEnabled: (String) -> Unit,
 ) {
     val context = LocalContext.current
@@ -89,7 +90,6 @@ fun MediaRPC(
     var isTimestampsEnabled by remember { mutableStateOf(Prefs[MEDIA_RPC_ENABLE_TIMESTAMPS, false]) }
     var hideOnPause by remember { mutableStateOf(Prefs[MEDIA_RPC_HIDE_ON_PAUSE, false]) }
     var isShowPlaybackState by remember { mutableStateOf(Prefs[MEDIA_RPC_SHOW_PLAYBACK_STATE, false]) }
-    var hasNotificationAccess by remember { mutableStateOf(context.hasNotificationAccess()) }
 
     val scrollBehavior = TopAppBarDefaults.exitUntilCollapsedScrollBehavior(
         rememberTopAppBarState(),
@@ -141,9 +141,8 @@ fun MediaRPC(
                     description = stringResource(id = R.string.request_for_notification_access),
                     icon = Icons.Default.Warning,
                 ) {
-                    when (context.hasNotificationAccess()) {
-                        true -> hasNotificationAccess = true
-                        false -> context.startActivity(Intent(Settings.ACTION_NOTIFICATION_LISTENER_SETTINGS))
+                    if (!hasNotificationAccess) {
+                        context.startActivity(Intent(Settings.ACTION_NOTIFICATION_LISTENER_SETTINGS))
                     }
                 }
             }