From 22072214255a61225e3e08d953d1107e0a98dd28 Mon Sep 17 00:00:00 2001 From: George Helman Date: Sun, 28 Apr 2024 23:00:19 -0400 Subject: [PATCH] More dev review changes --- .eslintrc.json | 1 - dear_petition/petition/api/viewsets.py | 6 +++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/.eslintrc.json b/.eslintrc.json index 38cff895..3712514a 100644 --- a/.eslintrc.json +++ b/.eslintrc.json @@ -40,7 +40,6 @@ ], "rules": { // Disabled default rules - "no-debugger": "off", "no-plusplus": "off", "no-continue": "off", "react/jsx-props-no-spreading": "off", diff --git a/dear_petition/petition/api/viewsets.py b/dear_petition/petition/api/viewsets.py index f91d28fb..1d7613b1 100644 --- a/dear_petition/petition/api/viewsets.py +++ b/dear_petition/petition/api/viewsets.py @@ -345,11 +345,11 @@ def combine_batches(self, request): if not batch_ids: return Response( - "No client uploads have been.", status=status.HTTP_400_BAD_REQUEST + "No client uploads have been uploaded.", status=status.HTTP_400_BAD_REQUEST ) - if not batch_ids: + if not label: return Response( - "No client uploads have been included.", status=status.HTTP_400_BAD_REQUEST + "A new label needs to be included for the client.", status=status.HTTP_400_BAD_REQUEST ) new_batch = combine_batches(batch_ids, label, user_id)