Skip to content

Add host keys to known_hosts file #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jacobdr opened this issue May 15, 2016 · 0 comments
Open

Add host keys to known_hosts file #3

jacobdr opened this issue May 15, 2016 · 0 comments

Comments

@jacobdr
Copy link

jacobdr commented May 15, 2016

Right now, the current implementation uses StrictHostKeyChecking=no to prevent interactive warning messages about unknown keys / authenticity from preventing the build process. However, this is not ideal, as we should try to check the validity of the host's public key during SSH connection setup (e.g. during calls to npm install git+ssh:...).

We should close this issue with a PR that uses one of the approaches outlined here to facilitate better security.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant