Skip to content

fix: docker image

fix: docker image #394

Triggered via pull request February 15, 2024 16:57
Status Success
Total duration 1m 48s
Artifacts

clippy-checks.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

12 warnings
accessing first element with `authchain.get(0)`: crates/benchmark/src/client.rs#L134
warning: accessing first element with `authchain.get(0)` --> crates/benchmark/src/client.rs:134:35 | 134 | serde_json::to_string(authchain.get(0).unwrap()).unwrap(), | ^^^^^^^^^^^^^^^^ help: try: `authchain.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
accessing first element with `auth_chain.get(0)`: crates/benchmark/src/client.rs#L60
warning: accessing first element with `auth_chain.get(0)` --> crates/benchmark/src/client.rs:60:35 | 60 | serde_json::to_string(auth_chain.get(0).unwrap()).unwrap(), | ^^^^^^^^^^^^^^^^^ help: try: `auth_chain.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first = note: `#[warn(clippy::get_first)]` on by default
accessing first element with `quest_w_reward_items.get(0)`: crates/db/src/core/tests.rs#L238
warning: accessing first element with `quest_w_reward_items.get(0)` --> crates/db/src/core/tests.rs:238:9 | 238 | quest_w_reward_items.get(0).unwrap().image_link, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `quest_w_reward_items.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
accessing first element with `quest_w_reward_items.get(0)`: crates/db/src/core/tests.rs#L236
warning: accessing first element with `quest_w_reward_items.get(0)` --> crates/db/src/core/tests.rs:236:16 | 236 | assert_eq!(quest_w_reward_items.get(0).unwrap().name, "SunGlasses"); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `quest_w_reward_items.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
accessing first element with `old_versions.get(0)`: crates/db/src/core/tests.rs#L115
warning: accessing first element with `old_versions.get(0)` --> crates/db/src/core/tests.rs:115:16 | 115 | assert_eq!(old_versions.get(0).unwrap(), &quest_id); | ^^^^^^^^^^^^^^^^^^^ help: try: `old_versions.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
accessing first element with `quests_by_creator.get(0)`: crates/db/src/core/tests.rs#L108
warning: accessing first element with `quests_by_creator.get(0)` --> crates/db/src/core/tests.rs:108:14 | 108 | assert!(!quests_by_creator.get(0).unwrap().active); | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `quests_by_creator.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
accessing first element with `quests_by_creator.get(0)`: crates/db/src/core/tests.rs#L107
warning: accessing first element with `quests_by_creator.get(0)` --> crates/db/src/core/tests.rs:107:16 | 107 | assert_eq!(quests_by_creator.get(0).unwrap().id, deactivated_quest); | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `quests_by_creator.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
accessing first element with `quests_by_creator.get(0)`: crates/db/src/core/tests.rs#L89
warning: accessing first element with `quests_by_creator.get(0)` --> crates/db/src/core/tests.rs:89:13 | 89 | assert!(quests_by_creator.get(0).unwrap().active); | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `quests_by_creator.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
accessing first element with `quests_by_creator.get(0)`: crates/db/src/core/tests.rs#L88
warning: accessing first element with `quests_by_creator.get(0)` --> crates/db/src/core/tests.rs:88:16 | 88 | assert_eq!(quests_by_creator.get(0).unwrap().id, new_quest_id); | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `quests_by_creator.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first = note: `#[warn(clippy::get_first)]` on by default
unused import: `prost::Message`: /home/runner/work/quests/quests/target/debug/build/quests_protocol-80959f626496eecf/out/decentraland.quests.rs#L503
warning: unused import: `prost::Message` --> /home/runner/work/quests/quests/target/debug/build/quests_protocol-80959f626496eecf/out/decentraland.quests.rs:503:5 | 503 | use prost::Message; | ^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
clippy_check
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: arduino/setup-protoc@v1, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
clippy_check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/