Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow attachments in comments #342

Open
6 tasks
aramollis opened this issue Oct 21, 2024 · 3 comments
Open
6 tasks

Allow attachments in comments #342

aramollis opened this issue Oct 21, 2024 · 3 comments

Comments

@aramollis
Copy link

aramollis commented Oct 21, 2024

A client want to be able to add attachments to comments (like we do for proposals eg.). This is an old feature request everyone agree (see in Meta Decidim, but seems easier to implement in Awesome however. We will develop this feature in next weeks if you are agree @microstudi ?

Proposed solution

As an admin (from the backend):
I can define from Awesome "editors settings" /admin/decidim_awesome/config/editors

  • You can allow attachments to comments.
  • You can restrict where spaces... this should happen
  • You can restrict the file types allowed (only available file types from config settings should appear here, to avoid conflicts)
Captura de Pantalla 2024-10-09 a les 20 04 23

As regular user (In the front):

  • User could add only 1 attachment per comment for allowed filetypes with new "attachment" field
  • Attachments shown as a list with minimal data (without tabs img/docs. Optional we can render a cropped thumb for images or not)
  • Only logged users should access to attachments in order to discourage spam. Maybe non-logged user should be able to see there is an attachment but ask to login for access.
    Captura de Pantalla 2024-10-10 a les 17 03 56

Alternatives considered
Implement in the core.

@microstudi
Copy link
Contributor

By all means @aramollis go ahead. You have our blessing. But maybe a couple of comments:
Downloading attachments should only be allowed for logged in people? to avoid turning decidim into a spam/download page
And, I think one attachement should be enough no? or you want to make galleries in the comment?

@aramollis
Copy link
Author

By all means @aramollis go ahead. You have our blessing. But maybe a couple of comments:
Downloading attachments should only be allowed for logged in people? to avoid turning decidim into a spam/download page
And, I think one attachement should be enough no? or you want to make galleries in the comment?

I will check with client but I think are both good points. Tx! If a user want to attach many docs can zip them.

@aramollis
Copy link
Author

Client confirmed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants