Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade 0.29 #362

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Upgrade 0.29 #362

wants to merge 23 commits into from

Conversation

antopalidi
Copy link
Member

Fixes #357

@antopalidi antopalidi marked this pull request as draft December 22, 2024 12:06
@antopalidi antopalidi marked this pull request as ready for review January 9, 2025 16:49
@antopalidi antopalidi requested a review from microstudi January 9, 2025 16:49
@codecov Codecov
Copy link

codecov bot commented Jan 9, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.27%. Comparing base (6c9476c) to head (0f4c15f).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...decidim/decidim_awesome/update_account_override.rb 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             main     #362       +/-   ##
===========================================
+ Coverage   68.85%   97.27%   +28.42%     
===========================================
  Files          80      143       +63     
  Lines        2106     3675     +1569     
===========================================
+ Hits         1450     3575     +2125     
+ Misses        656      100      -556

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

microstudi
microstudi reviewed Jan 10, 2025
View reviewed changes
Copy link
Contributor

@microstudi microstudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

You can also remove some more things related to the active storage migration.

See the file views/decidim/decidim_awesome/admin/checks/index.html.erb and everything related to the helper images_migrated?

lib/tasks/decidim_awesome_upgrade_tasks.rake Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@microstudi microstudi microstudi left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade Decidim Awesome to 0.29
2 participants
@antopalidi @microstudi