fix review points

Signed-off-by: Aleksandr Zimin <[email protected]>

Author: AleksZimin

cmd/dataexport.go

@@ -59,7 +59,6 @@ func init() {
 		deCreate.NewCommand(ctx, logger),
 		deDelete.NewCommand(ctx, logger),
 		deDownload.NewCommand(ctx, logger),
-		//deGet.NewCommand(),
 		deList.NewCommand(ctx, logger),
 	)
 

internal/dataexport/cmd/delete/delete.go

@@ -69,7 +69,7 @@ func parseArgs(args []string) (deName string, err error) {
 }
 
 func Run(ctx context.Context, log *slog.Logger, cmd *cobra.Command, args []string) error {
-	ctx, cancel := context.WithTimeout(ctx, 10*time.Second)
+	ctx, cancel := context.WithTimeout(ctx, 25*time.Second)
 	defer cancel()
 	namespace, _ := cmd.Flags().GetString("namespace")
 

internal/dataexport/cmd/download/download.go

@@ -124,7 +124,7 @@ func recursiveDownload(ctx context.Context, sClient *safeClient.SafeClient, log
 	defer resp.Body.Close()
 
 	if resp.StatusCode != 200 {
-		if resp.ContentLength > 0 && resp.ContentLength < 1000 {
+		if resp.ContentLength > 0 {
 			msg, err := io.ReadAll(io.LimitReader(resp.Body, 1000))
 			if err == nil {
 				return fmt.Errorf("Backend response \"%s\" Msg: %s", resp.Status, string(msg))

internal/dataexport/cmd/get/get.go

@@ -112,8 +112,8 @@ func downloadRaw(ctx context.Context, log *slog.Logger, namespace, deName, srcPa
 	defer resp.Body.Close()
 
 	if resp.StatusCode != 200 {
-		if resp.ContentLength > 0 && resp.ContentLength < 1000 {
-			msg, err := io.ReadAll(resp.Body)
+		if resp.ContentLength > 0 {
+			msg, err := io.ReadAll(io.LimitReader(resp.Body, 1000))
 			if err == nil {
 				return nil, fmt.Errorf("Backend response \"%s\" Msg: %s", resp.Status, string(msg))
 			}