Skip to content

Commit 0ba39d6

Browse files
committed
bump
Signed-off-by: Pavel Okhlopkov <[email protected]>
1 parent 455401b commit 0ba39d6

File tree

3 files changed

+62
-11
lines changed

3 files changed

+62
-11
lines changed

common-hooks/tls-certificate/internal_tls_test.go

Lines changed: 36 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ import (
3232
"github.com/deckhouse/module-sdk/pkg"
3333
"github.com/deckhouse/module-sdk/pkg/certificate"
3434
"github.com/deckhouse/module-sdk/pkg/jq"
35-
tframework "github.com/deckhouse/module-sdk/testing/framework"
35+
"github.com/deckhouse/module-sdk/testing/helpers"
3636
mock "github.com/deckhouse/module-sdk/testing/mock"
3737
)
3838

@@ -453,11 +453,23 @@ func Test_GenSelfSignedTLS_NewFramework(t *testing.T) {
453453

454454
hookConfig := tlscertificate.GenSelfSignedTLSConfig(tlsConfig)
455455

456-
f := tframework.NewHookFramework(t, hookConfig, tlscertificate.GenSelfSignedTLS(tlsConfig))
457-
458-
f.PrepareHookSnapshots(hookConfig, map[string][]string{
459-
tlscertificate.InternalTLSSnapshotKey: {
460-
`
456+
snaps := helpers.PrepareHookSnapshots(t, hookConfig, map[string]string{
457+
tlscertificate.InternalTLSSnapshotKey: `
458+
apiVersion: v1
459+
data:
460+
ca.crt: LS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tCk1JSUJpRENDQVM2Z0F3SUJBZ0lVV3VXcVhMQ1ZnWXVSaVNmZVZvT3RHMG9vU3pZd0NnWUlLb1pJemowRUF3SXcKSWpFZ01CNEdBMVVFQXhNWFpHVmphMmh2ZFhObExtUTRMWE41YzNSbGJTNXpkbU13SGhjTk1qVXdOakU0TVRnMApOREF3V2hjTk16VXdOakUyTVRnME5EQXdXakFpTVNBd0hnWURWUVFERXhka1pXTnJhRzkxYzJVdVpEZ3RjM2x6CmRHVnRMbk4yWXpCWk1CTUdCeXFHU000OUFnRUdDQ3FHU000OUF3RUhBMElBQkM0N3h1WCs2VkhvVVVpaG9VSUsKbzY1QzR2OVU5UjV5dXZLQUN3SlJ3bFoxUGs1MGR2aXFFNHJjbXRsdTRsZkRPSW9qaFlJN3ZUS1piMVByVTY3MgpTSHVqUWpCQU1BNEdBMVVkRHdFQi93UUVBd0lCQmpBUEJnTlZIUk1CQWY4RUJUQURBUUgvTUIwR0ExVWREZ1FXCkJCVDF1U3JvYjNJeHpaNlJOc042dEFjTGlyUGt3REFLQmdncWhrak9QUVFEQWdOSUFEQkZBaUJ6YTVSS3p0RDYKRmJuT2NOTm5ncjhQazhrME4vcGtzTGNiemZXd3NCN0lVQUloQU5tMjNMSzczNVJ0c3F4TGhGNmtyTCtlZmJicgpBbU9jSmpWdGwvNWc5aEhhCi0tLS0tRU5EIENFUlRJRklDQVRFLS0tLS0K
461+
tls.crt: LS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tCk1JSUIwakNDQVhpZ0F3SUJBZ0lVVk5uZTJHaE1vV2k2RUdSVlh3bW1Kak1OdU40d0NnWUlLb1pJemowRUF3SXcKSWpFZ01CNEdBMVVFQXhNWFpHVmphMmh2ZFhObExtUTRMWE41YzNSbGJTNXpkbU13SGhjTk1qVXdOakU0TVRnMApOREF3V2hjTk16VXdOakUyTVRnME5EQXdXakFpTVNBd0hnWURWUVFERXhka1pXTnJhRzkxYzJVdVpEZ3RjM2x6CmRHVnRMbk4yWXpCWk1CTUdCeXFHU000OUFnRUdDQ3FHU000OUF3RUhBMElBQlBSdWduRk1yMlFZM0lKSFhvNlAKSEN3ZnYxRVJyS0dQdXZMYVovNHI1QWNmUkhJT3AzYUNvR1pwT0JRbFRUejBSaTE3VDRVeStHdmZxRWg0MHVCNQowYldqZ1lzd2dZZ3dEZ1lEVlIwUEFRSC9CQVFEQWdXZ01Bd0dBMVVkRXdFQi93UUNNQUF3SFFZRFZSME9CQllFCkZPMmpYOXE5MDc0WHdkNU90RFVhOE9vaXJiNEtNRWtHQTFVZEVRUkNNRUNDRjJSbFkydG9iM1Z6WlM1a09DMXoKZVhOMFpXMHVjM1pqZ2lWa1pXTnJhRzkxYzJVdVpEZ3RjM2x6ZEdWdExuTjJZeTVqYkhWemRHVnlMbXh2WTJGcwpNQW9HQ0NxR1NNNDlCQU1DQTBnQU1FVUNJUUN6dEJGbEY2eEpueHYyS3hrNHNqam5mQjQ1YjRmdjNsTFJYVkp6CmZmL2lsZ0lnTXQvM3pHSXRqVndlV3B1eDdyZnN0RkxxalhtZmkwRk4xL3ZwWGtOTEljZz0KLS0tLS1FTkQgQ0VSVElGSUNBVEUtLS0tLQo=
462+
tls.key: LS0tLS1CRUdJTiBFQyBQUklWQVRFIEtFWS0tLS0tCk1IY0NBUUVFSUdIUUdieWlDdlV2WDdiUUhBbmZ2YkExbVdBLy9ESjlUdC83WW94akMvZ2dvQW9HQ0NxR1NNNDkKQXdFSG9VUURRZ0FFOUc2Q2NVeXZaQmpjZ2tkZWpvOGNMQisvVVJHc29ZKzY4dHBuL2l2a0J4OUVjZzZuZG9LZwpabWs0RkNWTlBQUkdMWHRQaFRMNGE5K29TSGpTNEhuUnRRPT0KLS0tLS1FTkQgRUMgUFJJVkFURSBLRVktLS0tLQo=
463+
kind: Secret
464+
metadata:
465+
creationTimestamp: "2025-06-18T18:48:49Z"
466+
labels:
467+
app: deckhouse
468+
heritage: deckhouse
469+
module: deckhouse
470+
name: admission-webhook-certs
471+
namespace: d8-system
472+
---
461473
apiVersion: v1
462474
data:
463475
ca.crt: LS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tCk1JSUJpRENDQVM2Z0F3SUJBZ0lVV3VXcVhMQ1ZnWXVSaVNmZVZvT3RHMG9vU3pZd0NnWUlLb1pJemowRUF3SXcKSWpFZ01CNEdBMVVFQXhNWFpHVmphMmh2ZFhObExtUTRMWE41YzNSbGJTNXpkbU13SGhjTk1qVXdOakU0TVRnMApOREF3V2hjTk16VXdOakUyTVRnME5EQXdXakFpTVNBd0hnWURWUVFERXhka1pXTnJhRzkxYzJVdVpEZ3RjM2x6CmRHVnRMbk4yWXpCWk1CTUdCeXFHU000OUFnRUdDQ3FHU000OUF3RUhBMElBQkM0N3h1WCs2VkhvVVVpaG9VSUsKbzY1QzR2OVU5UjV5dXZLQUN3SlJ3bFoxUGs1MGR2aXFFNHJjbXRsdTRsZkRPSW9qaFlJN3ZUS1piMVByVTY3MgpTSHVqUWpCQU1BNEdBMVVkRHdFQi93UUVBd0lCQmpBUEJnTlZIUk1CQWY4RUJUQURBUUgvTUIwR0ExVWREZ1FXCkJCVDF1U3JvYjNJeHpaNlJOc042dEFjTGlyUGt3REFLQmdncWhrak9QUVFEQWdOSUFEQkZBaUJ6YTVSS3p0RDYKRmJuT2NOTm5ncjhQazhrME4vcGtzTGNiemZXd3NCN0lVQUloQU5tMjNMSzczNVJ0c3F4TGhGNmtyTCtlZmJicgpBbU9jSmpWdGwvNWc5aEhhCi0tLS0tRU5EIENFUlRJRklDQVRFLS0tLS0K
@@ -473,7 +485,6 @@ metadata:
473485
name: admission-webhook-certs
474486
namespace: d8-system
475487
`,
476-
},
477488
})
478489

479490
values := mock.NewPatchableValuesCollectorMock(t)
@@ -486,9 +497,25 @@ metadata:
486497
assert.NotEmpty(t, value)
487498
})
488499

489-
f.HookInput.Values = values
500+
input := helpers.NewHookInput(t)
501+
input.Snapshots = snaps
502+
input.Values = values
490503

491-
err := f.Execute(context.TODO())
504+
config := tlscertificate.GenSelfSignedTLSHookConf{
505+
CN: "cert-name",
506+
TLSSecretName: "secret-webhook-cert",
507+
Namespace: "some-namespace",
508+
SANs: tlscertificate.DefaultSANs([]string{
509+
"example-webhook",
510+
"example-webhook.d8-example-module",
511+
"example-webhook.d8-example-module.svc",
512+
"%CLUSTER_DOMAIN%://example-webhook.d8-example-module.svc",
513+
"%PUBLIC_DOMAIN%://example-webhook.d8-example-module.svc",
514+
}),
515+
FullValuesPathPrefix: "d8-example-module.internal.webhookCert",
516+
}
517+
518+
err := tlscertificate.GenSelfSignedTLS(config)(context.Background(), input)
492519
assert.NoError(t, err)
493520
})
494521
}

testing/helpers/hook_input.go

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
package helpers
2+
3+
import (
4+
"testing"
5+
6+
"github.com/deckhouse/deckhouse/pkg/log"
7+
"github.com/deckhouse/module-sdk/pkg"
8+
"github.com/deckhouse/module-sdk/testing/mock"
9+
)
10+
11+
func NewHookInput(t *testing.T) *pkg.HookInput {
12+
return &pkg.HookInput{
13+
Snapshots: mock.NewSnapshotsMock(t),
14+
Values: mock.NewPatchableValuesCollectorMock(t),
15+
ConfigValues: mock.NewPatchableValuesCollectorMock(t),
16+
PatchCollector: mock.NewPatchCollectorMock(t),
17+
MetricsCollector: mock.NewMetricsCollectorMock(t),
18+
DC: mock.NewDependencyContainerMock(t),
19+
Logger: log.NewNop(),
20+
}
21+
}

testing/helpers/snapshots.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import (
44
"context"
55
"encoding/json"
66
"fmt"
7+
"strings"
78
"testing"
89

910
objectpatch "github.com/deckhouse/module-sdk/internal/object-patch"
@@ -14,9 +15,9 @@ import (
1415
)
1516

1617
// input snapshots must be in yaml format
17-
func PrepareHookSnapshots(t *testing.T, config *pkg.HookConfig, inputSnapshots map[string][]string) pkg.Snapshots {
18+
func PrepareHookSnapshots(t *testing.T, config *pkg.HookConfig, inputSnapshots map[string]string) pkg.Snapshots {
1819
formattedSnapshots := make(objectpatch.Snapshots, len(inputSnapshots))
19-
for snapBindingName, snaps := range inputSnapshots {
20+
for snapBindingName, rawSnaps := range inputSnapshots {
2021
var (
2122
err error
2223
query *jq.Query
@@ -30,6 +31,8 @@ func PrepareHookSnapshots(t *testing.T, config *pkg.HookConfig, inputSnapshots m
3031
}
3132
}
3233

34+
snaps := strings.Split(rawSnaps, "---")
35+
3336
for _, snap := range snaps {
3437
var yml map[string]interface{}
3538

0 commit comments

Comments
 (0)